diff --git a/cores/esp32/Tone.cpp b/cores/esp32/Tone.cpp index 3bc96ab7034..5ed55124f8e 100644 --- a/cores/esp32/Tone.cpp +++ b/cores/esp32/Tone.cpp @@ -95,6 +95,9 @@ void setToneChannel(uint8_t channel){ if(tone_init()){ tone_msg_t tone_msg = { .tone_cmd = TONE_SET_CHANNEL, + .pin = 0, // Ignored + .frequency = 0, // Ignored + .duration = 0, // Ignored .channel = channel }; xQueueSend(_tone_queue, &tone_msg, portMAX_DELAY); @@ -106,7 +109,10 @@ void noTone(uint8_t _pin){ if(tone_init()){ tone_msg_t tone_msg = { .tone_cmd = TONE_END, - .pin = _pin + .pin = _pin, + .frequency = 0, // Ignored + .duration = 0, // Ignored + .channel = 0 // Ignored }; xQueueSend(_tone_queue, &tone_msg, portMAX_DELAY); } @@ -124,7 +130,8 @@ void tone(uint8_t _pin, unsigned int frequency, unsigned long duration){ .tone_cmd = TONE_START, .pin = _pin, .frequency = frequency, - .duration = duration + .duration = duration, + .channel = 0 // Ignored }; xQueueSend(_tone_queue, &tone_msg, portMAX_DELAY); } diff --git a/cores/esp32/libb64/cdecode.c b/cores/esp32/libb64/cdecode.c index 47592b02ba8..c4712b79762 100644 --- a/cores/esp32/libb64/cdecode.c +++ b/cores/esp32/libb64/cdecode.c @@ -40,6 +40,7 @@ static int base64_decode_block_signed(const int8_t* code_in, const int length_in fragment = (int8_t)base64_decode_value_signed(*codechar++); } while (fragment < 0); *plainchar = (fragment & 0x03f) << 2; + // fall through case step_b: do { if (codechar == code_in+length_in){ @@ -51,6 +52,7 @@ static int base64_decode_block_signed(const int8_t* code_in, const int length_in } while (fragment < 0); *plainchar++ |= (fragment & 0x030) >> 4; *plainchar = (fragment & 0x00f) << 4; + // fall through case step_c: do { if (codechar == code_in+length_in){ @@ -62,6 +64,7 @@ static int base64_decode_block_signed(const int8_t* code_in, const int length_in } while (fragment < 0); *plainchar++ |= (fragment & 0x03c) >> 2; *plainchar = (fragment & 0x003) << 6; + // fall through case step_d: do { if (codechar == code_in+length_in){ diff --git a/cores/esp32/libb64/cencode.c b/cores/esp32/libb64/cencode.c index 48a0d30b7e9..f5388e5270e 100644 --- a/cores/esp32/libb64/cencode.c +++ b/cores/esp32/libb64/cencode.c @@ -44,6 +44,7 @@ int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, result = (fragment & 0x0fc) >> 2; *codechar++ = base64_encode_value(result); result = (fragment & 0x003) << 4; + // fall through case step_B: if (plainchar == plaintextend) { state_in->result = result; @@ -54,6 +55,7 @@ int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, result |= (fragment & 0x0f0) >> 4; *codechar++ = base64_encode_value(result); result = (fragment & 0x00f) << 2; + // fall through case step_C: if (plainchar == plaintextend) { state_in->result = result; diff --git a/libraries/WiFi/src/WiFiGeneric.cpp b/libraries/WiFi/src/WiFiGeneric.cpp index 457ea6a0d5e..0d775beca26 100644 --- a/libraries/WiFi/src/WiFiGeneric.cpp +++ b/libraries/WiFi/src/WiFiGeneric.cpp @@ -1327,6 +1327,7 @@ bool WiFiGenericClass::setDualAntennaConfig(uint8_t gpio_ant1, uint8_t gpio_ant2 // Set antenna default configuration wifi_ant_config_t ant_config = { .rx_ant_mode = WIFI_ANT_MODE_AUTO, + .rx_ant_default = WIFI_ANT_MAX, // Ignored in AUTO mode .tx_ant_mode = WIFI_ANT_MODE_AUTO, .enabled_ant0 = 0, .enabled_ant1 = 1,