Conversation
- Do not explicitly skip .git dir, all . files are ignored by default. - Set quiet level mask to 4 to ignore misspells that are disabled for automatic correction. In this case we want to allow "uint".
gumb0
reviewed
Oct 8, 2018
docs/Host_Guide.md
Outdated
| The implementation can be done in object-oriented manner. | ||
| The ::evmc_host_interface lists the methods any Host must implement. | ||
|
|
||
| Moreover, each of methods has a pointer to ::evmc_context |
gumb0
reviewed
Oct 8, 2018
docs/Host_Guide.md
Outdated
| The ::evmc_host_interface lists the methods any Host must implement. | ||
|
|
||
| Moreover, each of methods has a pointer to ::evmc_context | ||
| as a parameter. The context is owned entirely to the Host allowing a Host instance |
Member
There was a problem hiding this comment.
owned entirely by the Host or belongs entirely to the Host
Member
|
Comments about codespell change:
Perhaps with a different version of codespell, it did consume
There is a whitelist file to allow specific things which are caught by it otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly addresses #88.
Guide: https://2540-66214407-gh.circle-artifacts.com/0/docs/hostguide.html.