This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Merged
Conversation
axic
reviewed
May 8, 2019
Member
Author
|
I want to create a basic example of "Precompiles VM" implementation. Let me finish the full example first and the decide what can be merged to the master branch. |
axic
reviewed
May 8, 2019
This comment has been minimized.
This comment has been minimized.
chfast
force-pushed
the
precompiles-capacity
branch
2 times, most recently
from
24e33d0 to
feb9ef7
Compare
This comment has been minimized.
This comment has been minimized.
axic
suggested changes
May 8, 2019
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Should run the vmtester on the example (also need to extend the vmtester to cope with this).
Merged
chfast
force-pushed
the
precompiles-capacity
branch
2 times, most recently
from
ac85b48 to
3bbeb9b
Compare
axic
reviewed
May 9, 2019
axic
approved these changes
May 9, 2019
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Looks good, but I assume you'll squash some of the commits.
chfast
force-pushed
the
precompiles-capacity
branch
from
b79037e to
5f86929
Compare
Member
Author
|
Squashed. Do you think we should merge this? |
chfast
commented
May 9, 2019
axic
approved these changes
May 9, 2019
chfast
force-pushed
the
precompiles-capacity
branch
from
db0c517 to
2e9bd6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #259.