cpp: Rename result::raw() to result::release_raw()#293
Conversation
| ## [6.2.2] - unreleased | ||
|
|
||
| - Changed: [[#293](https://github.com/ethereum/evmc/pull/293)] | ||
| In C++ API `evmc::result::raw()` renamed to `evmc::result::release_raw()`. |
There was a problem hiding this comment.
I think it is, but the comment should at least be merged into 6.2
There was a problem hiding this comment.
It's breaking, but 6.2 has broken C++ API anyway. Besides, this method is used internally.
There was a problem hiding this comment.
Just checked, raw was introduced in 6.2.1 via #257. I don't think renaming it is fixing a bug, the bug was fixed before the renaming, wasn't it?
chfast
force-pushed
the
cpp_result_release_raw
branch
from
e2c87b5 to
3ffadec
Compare
|
Based on |
jakelang
left a comment
jakelang
left a comment
There was a problem hiding this comment.
leak_raw sounds ok as well. release_raw sounds to me like a destructor or something that releases the associated resources.
|
|
chfast
force-pushed
the
cpp_result_release_raw
branch
from
3ffadec to
a70e297
Compare
chfast
changed the title
|
Renamed to |
|
But "acquire" is the opposite of what happens. Maybe it could look fine if it were a free function like |
chfast
force-pushed
the
cpp_result_release_raw
branch
from
a70e297 to
3ffadec
Compare
chfast
changed the title
4 participants
No description provided.