Conversation
include/evmc/evmc.hpp
Outdated
| constexpr uint8_t parse_hex_digit(uint8_t d) noexcept | ||
| { | ||
| return static_cast<uint8_t>( | ||
| (d >= '0' && d <= '9') ? d - '0' : (d >= 'a' && d <= 'f') ? d - 'a' + 10 : d - 'A' + 10); |
There was a problem hiding this comment.
Any chance to abort on invalid hex digits? E.g. 0x123kkx_address ?
There was a problem hiding this comment.
This will be C++ parser error. But I've found in C++17 you can have literals like 0x0.000000000000000000000000000000000000p0_address so I added additional checks.
There was a problem hiding this comment.
I reckon it is not easy to add a test case (e.g. file which would not compile)?
There was a problem hiding this comment.
Not without creating custom testing framework in CMake.
|
Need to apply renaming to changelog. |
chfast
force-pushed
the
literals
branch
2 times, most recently
from
5d9a3e8 to
ed8ffa4
Compare
|
|
||
| namespace literals | ||
| { | ||
| namespace internal |
There was a problem hiding this comment.
Should internal stuff better go into separate header?
There was a problem hiding this comment.
So far I'm ok with having single header for C++ (now it's even better when helpers.hpp is gone).
3 participants
No description provided.