Conversation
chfast
force-pushed
the
tools_run_create
branch
3 times, most recently
from
b7d820a to
ecf6ae1
Compare
chfast
force-pushed
the
tools_run_create
branch
2 times, most recently
from
590721d to
8a61e92
Compare
gumb0
reviewed
Feb 16, 2021
tools/commands/run.cpp
Outdated
|
|
||
| const auto deploy_result = vm.execute(host, rev, deploy_msg, code.data(), code.size()); | ||
| if (deploy_result.status_code != EVMC_SUCCESS) | ||
| return 1; |
Member
There was a problem hiding this comment.
Perhaps output a message in this case.
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 93.54% 93.82% +0.28%
==========================================
Files 23 23
Lines 3422 3497 +75
==========================================
+ Hits 3201 3281 +80
+ Misses 221 216 -5 |
axic
reviewed
Mar 8, 2021
axic
reviewed
Mar 8, 2021
tools/commands/run.cpp
Outdated
| { | ||
| namespace | ||
| { | ||
| constexpr auto deploy_address = 0x000000000000000000000000000000000c9ea7ed_address; |
Member
There was a problem hiding this comment.
Why does this address has so many leading zeroes?
axic
reviewed
Mar 8, 2021
tools/commands/run.cpp
Outdated
| return 1; | ||
|
|
||
| auto& deployed_account = host.accounts[deploy_address]; | ||
| deployed_account.code = bytes(deploy_result.output_data, deploy_result.output_size); |
Member
Author
There was a problem hiding this comment.
MockedHost does not have any call/create logic, it just records the passed message.
axic
approved these changes
Mar 8, 2021
Member
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Okay for me, but left some questions.
chfast
force-pushed
the
tools_run_create
branch
2 times, most recently
from
2eac3cd to
f8a39a1
Compare
gumb0
reviewed
Mar 9, 2021
| auto vm = evmc::VM{evmc_create_example_vm()}; | ||
| std::ostringstream out; | ||
|
|
||
| const auto exit_code = cmd::run(vm, EVMC_PETERSBURG, 0, "FE", "", true, out); |
Member
There was a problem hiding this comment.
Nit: other hex strings are lowercase in this file.
Suggested change
| const auto exit_code = cmd::run(vm, EVMC_PETERSBURG, 0, "FE", "", true, out); | |
| const auto exit_code = cmd::run(vm, EVMC_PETERSBURG, 0, "fe", "", true, out); |
gumb0
approved these changes
Mar 9, 2021
chfast
force-pushed
the
tools_run_create
branch
from
f8a39a1 to
ed4dddf
Compare
chfast
force-pushed
the
tools_run_create
branch
from
ed4dddf to
c8c90e0
Compare
chfast
force-pushed
the
tools_run_create
branch
from
c8c90e0 to
6330289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.