This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Conversation
Member
Author
gumb0
reviewed
Aug 15, 2018
README.md
Outdated
| [@chfast]: https://github.com/chfast | ||
| [documentation]: https://ethereum.github.io/evmc | ||
| [eWASM]: https://github.com/ewasm/design#ethereum-flavored-webassembly-ewasm-design | ||
| [Ewasm]: https://github.com/ewasm/design#ethereum-flavored-webassembly-ewasm-design |
Member
There was a problem hiding this comment.
This anchor changed, I think now it's https://github.com/ewasm/design#what-is-ethereum-flavored-webassembly-ewasm
README.md
Outdated
|
|
||
| The EVMC is the low-level ABI between Ethereum Virtual Machines (EVMs) and | ||
| Ethereum Clients. On the EVM-side it supports classic EVM1 and [eWASM]. | ||
| Ethereum Clients. On the EVM-side it supports classic EVM1 and [Ewasm]. |
Member
There was a problem hiding this comment.
I think "EVM side" should be without dash
Member
There was a problem hiding this comment.
I don't think there's an agreement on the name, can you just have the wasm stuff in a separate PR?
docs/EVMC.md
Outdated
| - [EVMC Loader](@ref loader) | ||
| – the library for loading VMs implemented as Dynamically Loaded Libraries (DLLs, shared objects). | ||
| - [EVMC Helpers](@ref helpers) | ||
| – a collection of utility function for easier integration with EVMC. |
docs/EVMC.md
Outdated
| – the library with collection of metrics for EVM1 instruction set. | ||
|
|
||
|
|
||
| [Ewasm]: https://github.com/ewasm/design#ethereum-flavored-webassembly-ewasm-design |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Why does it need to link to the heading?
axic
reviewed
Aug 18, 2018
docs/EVMC.md
Outdated
| - Provides access to State. | ||
| - Creates new accounts (with code being a result of VM execution). | ||
| - Handles refunds entirely. | ||
| - Handles calls to precompiled contracts. |
axic
reviewed
Aug 18, 2018
|
|
||
| - Provides access to State. | ||
| - Creates new accounts (with code being a result of VM execution). | ||
| - Handles refunds entirely. |
Member
There was a problem hiding this comment.
Actually it may make sense moving that to the VM at some point.
Member
|
Okay apar from the ewasm naming question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.