This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Merged
Conversation
chfast
force-pushed
the
optional_storage
branch
2 times, most recently
from
8370b8c to
9dffef7
Compare
gumb0
approved these changes
Aug 15, 2018
Member
gumb0
left a comment
gumb0
left a comment
There was a problem hiding this comment.
If they are a disctinct separate group, it might make sense to move them to separate header, otherwise looks good to me.
axic
reviewed
Aug 18, 2018
include/evmc/helpers.h
Outdated
| * Helpers for optional storage of evmc_result. | ||
| * | ||
| * In some contexts (i.e. evmc_result::create_address is unused) objects of | ||
| * type evmc_result contains a memory storage that MAY be uses by the object |
chfast
force-pushed
the
optional_storage
branch
from
9dffef7 to
488bd5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Result Optional Storage to it's own group in EVMC Helpers.
See documentation: https://636-66214407-gh.circle-artifacts.com/0/docs/index.html.