eof: Move type validation outside of header validation#1052
Merged
Conversation
chfast
force-pushed
the
eof/validate_types
branch
from
889154c to
2f4daf5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
- Coverage 94.23% 94.23% -0.01%
==========================================
Files 155 155
Lines 16004 15997 -7
==========================================
- Hits 15082 15075 -7
Misses 922 922
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdobacz
approved these changes
Oct 15, 2024
Member
pdobacz
left a comment
pdobacz
left a comment
There was a problem hiding this comment.
LGTM. Such refactor was considered earlier. I completely don't recall the reasons why this didn't go through back then. Looks all good now 🤷
Member
Author
|
I think #1034 was a prerequisite. I fuzzed these two PRs. |
This allows separate header and type validation and simplify the implementation of the former.
chfast
force-pushed
the
eof/validate_types
branch
from
2f4daf5 to
d304085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows separate header and type validation and simplify the implementation of the former.