Always keep current instruction pointer in a register#133
Merged
Conversation
chfast
force-pushed
the
next_instr
branch
2 times, most recently
from
142e5bf to
89e9368
Compare
This changes the signature of functions implementing instructions and the main loop. The pointer to current instructions has been removed from the state object, is now passed as an argument (rdi register) and next instruction pointer is returned from the instruction function (rax register).
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 84.18% 84.35% +0.16%
==========================================
Files 19 19
Lines 2055 2128 +73
Branches 218 218
==========================================
+ Hits 1730 1795 +65
- Misses 300 308 +8
Partials 25 25 |
jwasinger
pushed a commit
to jwasinger/evmone
that referenced
this pull request
Apr 27, 2021
Go: support create2_salt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the signature of functions implementing instructions and the main loop. The pointer to current instructions has been removed from the state object, is now passed as an argument (rdi register) and next instruction pointer is returned from the instruction function (rax register).