Conversation
chfast
force-pushed
the
synth_benchmarks
branch
6 times, most recently
from
77ce0e8 to
88e5085
Compare
chfast
force-pushed
the
synth_benchmarks
branch
2 times, most recently
from
5e34b29 to
440c0dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 24 24
Lines 3655 3655
=======================================
Hits 3646 3646
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. |
chfast
force-pushed
the
synth_benchmarks
branch
from
440c0dc to
a24a30a
Compare
gumb0
reviewed
Jan 6, 2021
gumb0
reviewed
Jan 6, 2021
gumb0
reviewed
Jan 6, 2021
test/bench/synthetic_benchmarks.cpp
Outdated
| switch (kind) | ||
| { | ||
| case InstructionKind::push: | ||
| return stack_limit * (push(opcode, {}) + OP_POP); |
Member
There was a problem hiding this comment.
What's the idea behind using stack_limit as a limit in min_stack mode? It could as well fill up the code size limit.
Member
Author
There was a problem hiding this comment.
You can notice that both min_stack and full_stack have exactly the same instructions just with different order.
gumb0
reviewed
Jan 6, 2021
gumb0
reviewed
Jan 6, 2021
gumb0
reviewed
Jan 6, 2021
gumb0
reviewed
Jan 6, 2021
gumb0
reviewed
Jan 6, 2021
chfast
force-pushed
the
synth_benchmarks
branch
7 times, most recently
from
d648378 to
151fc83
Compare
axic
reviewed
Jan 16, 2021
axic
reviewed
Jan 16, 2021
axic
reviewed
Jan 16, 2021
axic
reviewed
Jan 16, 2021
chfast
force-pushed
the
synth_benchmarks
branch
3 times, most recently
from
bdc3fa3 to
0ababf7
Compare
chfast
commented
Jan 17, 2021
axic
reviewed
Jan 17, 2021
axic
reviewed
Jan 17, 2021
axic
reviewed
Jan 17, 2021
axic
reviewed
Jan 17, 2021
axic
reviewed
Jan 17, 2021
chfast
force-pushed
the
synth_benchmarks
branch
2 times, most recently
from
09f8b59 to
49f30b7
Compare
gumb0
reviewed
Jan 18, 2021
This was referenced Jan 19, 2021
chfast
force-pushed
the
synth_benchmarks
branch
3 times, most recently
from
1a3611f to
21a5198
Compare
gumb0
reviewed
Feb 11, 2021
This introduces a set of on-demand generated EVM bytecodes available in the evmone-bench tool. Each bytecode tries to stress a single "low-level" EVM instruction. Instructions are grouped by their stack requirements and there are also two main modes of the structure of the generated bytecodes.
gumb0
approved these changes
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://notes.ethereum.org/@chfast/benchmarking-evm-instructions