Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 94.13% 93.84% -0.30%
==========================================
Files 146 146
Lines 16259 15439 -820
==========================================
- Hits 15305 14488 -817
+ Misses 954 951 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
requested changes
Sep 9, 2024
gumb0
force-pushed
the
eof/remove-txcreate
branch
from
b454b49 to
c148044
Compare
chfast
reviewed
Sep 9, 2024
pdobacz
reviewed
Sep 9, 2024
Member
pdobacz
left a comment
pdobacz
left a comment
There was a problem hiding this comment.
compute_initcode_list_costshould be able to be removed nowtx.initcodesTransaction::Type::initcodes- possibly state test export and loader facilities?
https://github.com/ethereum/evmone/pull/702/files is my source, so maybe some are obsolete or maybe I haven't picked up all, sorry if these are already handled and I've missed
| tx.to = To; | ||
| pre.insert(*tx.to, {.nonce = 1, .code = factory_container}); | ||
|
|
||
| expect.tx_error = INIT_CODE_COUNT_LIMIT_EXCEEDED; |
Member
There was a problem hiding this comment.
This and a few other errors can be undefined now
case INIT_CODE_SIZE_LIMIT_EXCEEDED:
return "max initcode size exceeded";
case INIT_CODE_EMPTY:
return "initcode empty";
case INIT_CODE_COUNT_LIMIT_EXCEEDED:
return "max initcode count exceeded";
case INIT_CODE_COUNT_ZERO:
return "initcode list empty";
d5b2bfa to
5f24411
Compare
chfast
approved these changes
Sep 10, 2024
Member
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
Very nice, thanks.
Please add a PR description before merging.
pdobacz
approved these changes
Sep 10, 2024
gumb0
force-pushed
the
eof/remove-txcreate
branch
from
5f24411 to
814b8cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TXCREATEand initcode transactions are not scheduled for any upgrade currently, and it doesn't make sense to maintain this code at the moment.