core/types: handle nil ChainId in NewEIP155Signer

fjl · fjl · commit 67c47459f283 · 2017-03-23T15:58:42.000+01:00
All uses of ChainConfig.ChainId eventually end up in NewEIP155Signer.
This fixes the case where users forget to set the ChainId in their
config.
diff --git a/core/types/transaction_signing.go b/core/types/transaction_signing.go
@@ -112,6 +112,9 @@ type EIP155Signer struct {
 }
 
 func NewEIP155Signer(chainId *big.Int) EIP155Signer {
+	if chainId == nil {
+		chainId = new(big.Int)
+	}
 	return EIP155Signer{
 		chainId:    chainId,
 		chainIdMul: new(big.Int).Mul(chainId, big.NewInt(2)),

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,9 @@ type EIP155Signer struct {`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`func NewEIP155Signer(chainId *big.Int) EIP155Signer {`
	`115`	`+ if chainId == nil {`
	`116`	`+ chainId = new(big.Int)`
	`117`	`+ }`
`115`	`118`	`return EIP155Signer{`
`116`	`119`	`chainId: chainId,`
`117`	`120`	`chainIdMul: new(big.Int).Mul(chainId, big.NewInt(2)),`