cmd/abigen, accounts/abi/bind: implement abigen version 2#26782

Closed

s1na wants to merge 204 commits intoethereum:masterfrom

s1na:abigen2

Commits on Jan 22, 2025

accounts/abi: abigen v2

s1na
authored and
fjl
committed
add copyright header to lib.go

s1na
authored and
fjl
committed
drop unnecessary imports

s1na
authored and
fjl
committed
replace fmt with errors

authored and
fjl
committed
drop fmt

s1na
authored and
fjl
committed
skip unpack method when no return args

s1na
authored and
fjl
committed
define contract instance type

s1na
authored and
fjl
committed
Add deploy code to contract struct

s1na
authored and
fjl
committed
Pass pointer to log for unpack

s1na
authored and
fjl
committed
clean lang selection leftovers

s1na
authored and
fjl
committed
fix test

s1na
authored and
fjl
committed
add back code that got mistakenly removed in the rebase

jwasinger
authored and
fjl
committed
fix last rebase regression

jwasinger
authored and
fjl
committed
isolate V2 contract interaction API into its own package

jwasinger
authored and
fjl
committed
move v2 contract interaction methods into v2 package. add test

jwasinger
authored and
fjl
committed
stage point before I try to dedup contract interaction api

jwasinger
authored and
fjl
committed
still in a wip state

jwasinger
authored and
fjl
committed
dependency graph calculation working

jwasinger
authored and
fjl
committed
commit of wip-code: rework the contract deployment code to be cleaner

jwasinger
authored and
fjl
committed
rework contract deployment API

jwasinger
authored and
fjl
committed
closer to test passing now...

jwasinger
authored and
fjl
committed
fix contract

jwasinger
authored and
fjl
committed
update library test contract to have constructor with inputs. remove some debug print statements

jwasinger
authored and
fjl
committed
format improvements

jwasinger
authored and
fjl
committed
add missing files from testdata. refactor contract deployment API to be cleaner

jwasinger
authored and
fjl
committed
more docs. fix nested library contract. fix associated test case.

jwasinger
authored and
fjl
committed
fix v2 test

jwasinger
authored and
fjl
committed
some more docs

jwasinger
authored and
fjl
committed
simplify generated code for list of library dependencies

jwasinger
authored and
fjl
committed
remove old half-written test case with events (I will add it back in when I complete it).

jwasinger
authored and
fjl
committed
make tests run again

jwasinger
authored and
fjl
committed
add copyright notices. move v2 template to its own file. Rename V2Backend->BackendV2

jwasinger
authored and
fjl
committed
various small fixes: better error message, remove unecessary comments. address review about missing word in function documentation.

jwasinger
authored and
fjl
committed
add test for overrides

jwasinger
authored and
fjl
committed
add test coverage for events watching

jwasinger
authored and
fjl
committed
add coverage for event filtering

jwasinger
authored and
fjl
committed
return multiple results in exported struct (instead of anonymous one). add return_structs contract example to have an example of it.

jwasinger
authored and
fjl
committed
add errors to emitted code.

jwasinger
authored and
fjl
committed
add error unpacking. simplify WatchLogs api.

jwasinger
authored and
fjl
committed
fix contract filter test. rename *Logs methods to *Events, to reflect the fact that these are specific to solidity events.

jwasinger
authored and
fjl
committed
delete unused test data. remove useless v2 helper methods. update tests

jwasinger
authored and
fjl
committed
remove unused error test, other unused code in tests

jwasinger
authored and
fjl
committed
small cleanups

jwasinger
authored and
fjl
committed
add binding generation test

jwasinger
authored and
fjl
committed
add generic log watching/filtering. skip adding generic call/transact (issue with interface regarding contract methods that don't take arguments)

jwasinger
authored and
fjl
committed
add generic call/transact

jwasinger
authored and
fjl
committed
add db example from sina

jwasinger
authored and
fjl
committed
remove unecessary abi parameter from WatchEvents. simplify event tests

jwasinger
authored and
fjl
committed
mv test contracts to internal directory under v2

jwasinger
authored and
fjl
committed
staging changes for linking tests. rework LinkAndDeploy to decouple logic of contract deployment, by passing a callback that does it.

jwasinger
authored and
fjl
committed
wip

jwasinger
authored and
fjl
committed
basic linking test working

jwasinger
authored and
fjl
committed
add test cases for contract linking that I forgot to push earlier. Fix deployment logic (apparently modifying a map in-place during iteration is not safe????

jwasinger
authored and
fjl
committed
wip: update

jwasinger
authored and
fjl
committed
fix test cases

jwasinger
authored and
fjl
committed
one more test

jwasinger
authored and
fjl
committed
make link test case input be its own struct

jwasinger
authored and
fjl
committed
rewrite contract link/deploy again

jwasinger
authored and
fjl
committed
fix linking tests

jwasinger
authored and
fjl
committed
tests working now

jwasinger
authored and
fjl
committed
remove debug prints. fix contract linking test condition

jwasinger
authored and
fjl
committed
generation of custom error unpacking builds (not tested yet)

jwasinger
authored and
fjl
committed
wip (just committing so that I can rebase off master to use ethclient.RevertErrorData)

jwasinger
authored and
fjl
committed
full support for errors with working test

jwasinger
authored and
fjl
committed
change semantics of contract overrides again: any direct/indirect dependencies of contracts/libraries specified with override addresses should not be deployed if they are not elsewhere referenced …

jwasinger
authored and
fjl
committed
clean up link/deploy code. add docs

jwasinger
authored and
fjl
committed
gofmt files. add a TODO comment and remove another useless comment

jwasinger
authored and
fjl
committed
fix regex for solc pattern matching

jwasinger
authored and
fjl
committed
move contract dep tree, link-and-deploy to bind package. This is so that bind can build the dependency tree for each library to populate their exported deps.

jwasinger
authored and
fjl
committed
add some docs

jwasinger
authored and
fjl
committed
move abigen2 specific bind code into BindV2. fix broken v1 tests

jwasinger
authored and
fjl
committed
export event names in bindings. remove added APIs Filter/Watch-Logs which take event ids.

jwasinger
authored and
fjl
committed
update dep tree

jwasinger
authored and
fjl
committed
remove TODO comment about adding a test case that I have added

jwasinger
authored and
fjl
committed
regenerate bindings

jwasinger
authored and
fjl
committed
add comment for tmplError struct and remove unused v2 backend interface

jwasinger
authored and
fjl
committed
remove field that I added to abi.Error and never used

jwasinger
authored and
fjl
committed
wip...

jwasinger
authored and
fjl
committed
refactor builds

jwasinger
authored and
fjl
committed
tests pass

jwasinger
authored and
fjl
committed
remove unecessarily-added method

jwasinger
authored and
fjl
committed
add docs

jwasinger
authored and
fjl
committed
move BindV2 and methods it depends on into their own file.

jwasinger
authored and
fjl
committed
make DeploymentParams fields private. instantiate it with a constructor method

jwasinger
authored and
fjl
committed
fix comment for bindError method

jwasinger
authored and
fjl
committed
Update accounts/abi/bind/dep_tree.go

authored and
fjl
committed
Update accounts/abi/bind/dep_tree.go

authored and
fjl
committed
Update accounts/abi/bind/dep_tree.go

authored and
fjl
committed
wip: embed library relations in metadata

jwasinger
authored and
fjl
committed
embed direct library relations in metadata in bindings. simplify dependency tree handling as a result of embedding it in the bindings.

jwasinger
authored and
fjl
committed
accounts/abi/bind: simplifications

holiman
authored and
fjl
committed
clarifications

holiman
authored and
fjl
committed
accounts/abi/bind: make link test case failure output the index of the subtest that failed.

jwasinger
authored and
fjl
committed
accounts/abi/bind: don't define link test case table as a package-private variable

jwasinger
authored and
fjl
committed
accounts/abi/bind: remove unused fields from template structs

jwasinger
authored and
fjl
committed
wip

jwasinger
authored and
fjl
committed
fix events/error args normalization capitalization. add unit test that fails before the fix, and also also a few more test cases for args normalization.

jwasinger
authored and
fjl
committed
simplify vars naming in normalizeArgs

jwasinger
authored and
fjl
committed
remove capitalize helper method. simplify call/event/error symbol name registration

jwasinger
authored and
fjl
committed
copy DeploymentParams overrides before creating tree deployer (prevent the backing-array provided by the API user from being mutated). re-enable deployment-with-overrides test

jwasinger
authored and
fjl
committed
remove error return from generated pack method for constructors. add the results of feeding v1 binding test ABIs through the v2 generator.

jwasinger
authored and
fjl
committed
accounts/abi/bind/v2: fix lib_test.go (update test to reflect that bindings changed s.t. constructor unpack does not return error)

jwasinger
authored and
fjl
committed
accounts/abi/bind: remove duplicate convertedv1bindtests

jwasinger
authored and
fjl
committed
accounts/abi/bind/v2/internal/contracts: regenerate bindings (they were mistakenly generated with a broken iteration of the code, and empty/broken bindings were included)

jwasinger
authored and
fjl
committed
accounts/abi/bind: deduplicate logic to normalize struct elements, event/error/method arguments/results. fix for case where normalization of name '_' would return an empty string

jwasinger
authored and
fjl
committed
accounts/abi/bind/v2/internal/contracts: update bindings

jwasinger
authored and
fjl
committed
accounts/abi/bind: fix some ugliness in the generated binding code which deals with pointer types

jwasinger
authored and
fjl
committed
update converted v1 bind test cases. rename test case that checks converted-v1 bindings in v2 to something more sensible

jwasinger
authored and
fjl
committed
remove useless todo in v2 template

jwasinger
authored and
fjl
committed
better naming for instance of self-struct in member methods of structs in generated bindings

jwasinger
authored and
fjl
committed
accounts/abi/bind, accounts/abi/bind/v2: move DeployContractRaw into v2 package

jwasinger
authored and
fjl
committed
accounts/abi/bind: simplify bindv2: create constructors for contractBinder, tmplContractV2. move some sanitization of values loaded from ABI definition into tmplContractV2 constructor

jwasinger
authored and
fjl
committed
misc template additions I forgot to include in previous commits. introduce 'RawDeploymentTransact' method

jwasinger
authored and
fjl
committed
remove unused comment. add method description for RawCreationTransact

jwasinger
authored and
fjl
committed
update converted v1 bindings

jwasinger
authored and
fjl
committed
reenable TestBindingV2ConvertedV1Tests

jwasinger
authored and
fjl
committed
address some recent feedback. add docs about what the binder and contractBinder structs are used for.

jwasinger
authored and
fjl
committed
add docs explaining internal variables on the v2 binder/contractBinder structs. convert exported metadata object in binding to be non-pointer type. Fix some linter issues. remove unecessary TODO…

jwasinger
authored and
fjl
committed
don't emit constructor input packing method if the contract constructor has no inputs

jwasinger
authored and
fjl
committed
add TODO note about cleaning up template code for return values

jwasinger
authored and
fjl
committed
accounts/abi/bind/v2: fix Call helper method: don't return a pointer to the generic unpacked type (b/c it may be a pointer itself in the case of *big.Int underlying type. in this case, double-po…

jwasinger
authored and
fjl
committed
accounts/abi/bind: remove unecessary TODO from v2 template

jwasinger
authored and
fjl
committed
accounts/abi/bind/v2: fix test that doesn't compile

jwasinger
authored and
fjl
committed
accounts/abi/bind/v2: remove unecessary TODOs. Fix TestErrors compilation

jwasinger
authored and
fjl
committed
accounts/abi/bind, accounts/abi/bind/v2: fix error unpacking. update relevant binding example. make error unpacking test more comprehensive

jwasinger
authored and
fjl
committed
fix test 'BindingV2ConvertedV1Tests'. add more comprehensive output checking to solc errors test.

jwasinger
authored and
fjl
committed
accounts/abi/bind: un-embed+ make test nicer

holiman
authored and
fjl
committed
accounts/abi/bind/v2: remove some unnecessary type parameters
fjl
committed
accounts/abi/bind/v2: rename package to "bind" and reexport some v1 stuff
fjl
committed
accounts/abi/bind/v2: add ContractInstance constructor
fjl
committed
accounts/abi/bind: rename field in MetaData
fjl
committed
accounts/abi/bind/v2: pass contract instance as value
fjl
committed
accounts/abi/bind: update v2 template
fjl
committed
accounts/abi/bind/v2: update generated bindings for test
fjl
committed
accounts/abi/bind/v2: support passing nil unpack function in Call
fjl
committed
accounts/abi/bind/v2: update tests
fjl
committed
accounts/abi/bind: update converted v1 bind tests
fjl
committed
accounts/abi/bind: remove third return value of DeployContractRaw
fjl
committed
accounts/abi/bind: fix warning about assignment to blank
fjl
committed
accounts/abi/bind: fix some more warnings
fjl
committed
accounts/abi/bind: move code generator to accounts/abi/abigen
fjl
committed
accounts/abi/bind: add missing function
fjl
committed
accounts/abi/bind: move implementation to v2 package
fjl
committed
accounts/abi/bind/v2: remove deprecated TransactOpts constructors in v2
fjl
committed
accounts/abi/bind: fixup
fjl
committed

cmd/abigen, accounts/abi/bind: implement abigen version 2#26782s1na wants to merge 204 commits intoethereum:masterethereum/go-ethereum:masterfrom s1na:abigen2s1na/go-ethereum:abigen2Copy head branch name to clipboard

Commits

Commits on Jan 22, 2025

cmd/abigen, accounts/abi/bind: implement abigen version 2#26782
s1na wants to merge 204 commits intoethereum:masterfrom
s1na:abigen2