Export to Gist #2522
Merged
Export to Gist #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if "id" is not defined, it is not a gist update but a creation. we have to take the file from the browser explorer
LianaHus
reviewed
Jan 9, 2020
| @@ -470,7 +470,8 @@ fileExplorer.prototype.toGist = function (id) { | |||
| return data.files || [] | |||
| } | |||
|
|
|||
| this.packageFiles(this.files, 'browser/gists/' + id, (error, packaged) => { | |||
| const folder = id ? 'browser/gists/' + id : 'browser/' | |||
There was a problem hiding this comment.
would be nice to have the comment here
There was a problem hiding this comment.
"If 'id' is not defined, it is not a gist update but a creation. we have to take the file from the browser explorer."
LianaHus
approved these changes
Jan 9, 2020
yann300
force-pushed
the
yann300-patch-2
branch
7 times, most recently
from
5a2252a to
e08abd5
Compare
yann300
force-pushed
the
yann300-patch-2
branch
from
e08abd5 to
bd75dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "id" is not defined, it is not a gist update but a creation. we have to take the file from the browser explorer.
How could we add browser test for this? (cause we are testing against an external provider) @LianaHus @Aniket-Engg