Fix loading content from node_modules & browser tests #2533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
fixLoadingNodeModules
branch
14 times, most recently
from
97577ca to
f193ec6
Compare
yann300
commented
Jan 16, 2020
| * | ||
| * @param {String} url - URL of the content. can be basically anything like file located in the browser explorer, in the localhost explorer, raw HTTP, github address etc... | ||
| * @param {Function} cb - callback | ||
| */ | ||
| importFileCb (url, filecb) { |
There was a problem hiding this comment.
make sure to review that file please, this one is critical
yann300
commented
Jan 16, 2020
| tearDown: sauce | ||
| } | ||
|
|
||
| var abstractENS = ` |
There was a problem hiding this comment.
the testing code for abstractENS is removed. it was anyway not used
yann300
force-pushed
the
fixLoadingNodeModules
branch
from
f193ec6 to
1ce1a1f
Compare
|
@Aniket-Engg added some changes and a comment |
Aniket-Engg
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Bug Fix in the import feature: https://github.com/ethereum/remix-ide/pull/2533/files#diff-e227e6b79c5fc6ae43acfb5690d28895R111 : it was no longer possible to import a solidity file from node_modules folder using (see https://github.com/ethereum/remix-ide/pull/2533/files#diff-e227e6b79c5fc6ae43acfb5690d28895R105)
the test for this is there https://github.com/ethereum/remix-ide/pull/2533/files#diff-f6ea416db1949f98e79690ed8b52a110R50
add more e2e tests, mostly about importing files from github