pass compiler configuration to remix-tests #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
approved these changes
Jan 27, 2020
src/app/tabs/test-tab.js
Outdated
| @@ -166,13 +173,19 @@ module.exports = class TestTab extends ViewPlugin { | |||
| runTest (testFilePath, callback) { | |||
| this.loading.hidden = false | |||
| this.fileManager.getFile(testFilePath).then((content) => { | |||
| var runningTest = {} | |||
| let runningTest = {} | |||
There was a problem hiding this comment.
you can use const
| optimize, | ||
| usingWorker: canUseWorker(currentVersion) | ||
| } | ||
| remixTests.runTestSources(runningTest, compilerConfig, () => {}, () => {}, (error, result) => { |
There was a problem hiding this comment.
this is exacly for this kind of case that I would recommend an object argument instead of a list of ordered arguments (see comment here).
LianaHus
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to remix-project-org/remix#1410