Skip to content

[yul] Allow unicode directional sequences in comments and string literals #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mijovic opened this issue Dec 15, 2020 · 1 comment
Closed

[yul] Allow unicode directional sequences in comments and string literals #10622

mijovic opened this issue Dec 15, 2020 · 1 comment

Comments

@mijovic
Copy link
Contributor

mijovic commented Dec 15, 2020

Extracted from here #10326 (comment)

Currently AsmParser fails because these characters are considered illegal. Also it fails with rather bad message:

ParserError 1856: (35-47): Literal or identifier expected.

and it looks misleading. So, we need to decide, are we allowing these in comments and if not, should we consider changing error message.
@mijovic mijovic mentioned this issue Dec 15, 2020
Merged
5 tasks
@mijovic
Copy link
Contributor Author

mijovic commented Jan 12, 2021

Fixed by #10625

@mijovic mijovic closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mijovic