Skip to content

Commit fde527b

Browse files
committed
Revert "drm/msm/sde: Introduce KCAL color control"
This reverts commit dc89310.
1 parent 2180627 commit fde527b

5 files changed

Lines changed: 0 additions & 316 deletions

File tree

drivers/gpu/drm/msm/Kconfig

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -185,15 +185,6 @@ config EXPOSURE_ADJUSTMENT
185185
help
186186
The EXPOSURE ADJUSTMENT provides exposure adjustment function without change
187187
panel hardware brightness to avoid PWM flicker on OLED devices.
188-
189-
config DRM_MSM_KCAL_CTRL
190-
bool "Enable kernel-level color calibration control"
191-
depends on DRM_MSM
192-
default y
193-
help
194-
Choose this option for kernel-level color calibration control.
195-
This will adjust every atomic operation pcc and hsic call
196-
configuration with the values from kernel.
197188

198189
config DRM_SDE_EVTLOG_DEBUG
199190
bool "Enable event logging in MSM DRM"

drivers/gpu/drm/msm/Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ msm_drm-y := \
6060
msm_drm-$(CONFIG_DEBUG_FS) += sde_dbg.o \
6161
sde_dbg_evtlog.o
6262

63-
msm_drm-$(CONFIG_DRM_MSM_KCAL_CTRL) += sde/sde_hw_kcal_ctrl.o
64-
6563
msm_drm-$(CONFIG_DRM_MSM_HDMI) += hdmi/hdmi.o \
6664
hdmi/hdmi_audio.o \
6765
hdmi/hdmi_bridge.o \

drivers/gpu/drm/msm/sde/sde_hw_kcal_ctrl.c

Lines changed: 0 additions & 201 deletions
This file was deleted.

drivers/gpu/drm/msm/sde/sde_hw_kcal_ctrl.h

Lines changed: 0 additions & 81 deletions
This file was deleted.

drivers/gpu/drm/msm/sde/sde_hw_reg_dma_v1_color_proc.c

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "sde_reg_dma.h"
1414
#include "sde_hw_reg_dma_v1_color_proc.h"
1515
#include "sde_hw_color_proc_common_v4.h"
16-
#include "sde_hw_kcal_ctrl.h"
1716
#include "sde_hw_ctl.h"
1817
#include "sde_hw_sspp.h"
1918
#include "sde_hwio.h"
@@ -1037,23 +1036,11 @@ reg_dmav1_setup_dspp_pa_hsicv17_apply(struct sde_hw_dspp *ctx,
10371036
return rc;
10381037
}
10391038

1040-
static inline void
1041-
reg_dmav1_setup_dspp_pa_hsicv17_kcal(struct sde_hw_dspp *ctx, void *ctl)
1042-
{
1043-
struct drm_msm_pa_hsic hsic_cfg = sde_hw_kcal_hsic_struct();
1044-
int rc;
1045-
1046-
rc = reg_dmav1_setup_dspp_pa_hsicv17_apply(ctx, &hsic_cfg, ctl);
1047-
if (rc)
1048-
pr_err("kernel hsic application failed ret %d\n", rc);
1049-
}
1050-
10511039
void reg_dmav1_setup_dspp_pccv4(struct sde_hw_dspp *ctx, void *cfg)
10521040
{
10531041
struct sde_hw_reg_dma_ops *dma_ops;
10541042
struct sde_reg_dma_kickoff_cfg kick_off;
10551043
struct sde_hw_cp_cfg *hw_cfg = cfg;
1056-
struct sde_hw_kcal *kcal = sde_hw_kcal_get();
10571044
struct sde_reg_dma_setup_ops_cfg dma_write_cfg;
10581045
struct drm_msm_pcc *pcc_cfg;
10591046
struct drm_msm_pcc_coeff *coeffs = NULL;
@@ -1125,10 +1112,6 @@ void reg_dmav1_setup_dspp_pccv4(struct sde_hw_dspp *ctx, void *cfg)
11251112
data[i + 3] = coeffs->r;
11261113
data[i + 6] = coeffs->g;
11271114
data[i + 9] = coeffs->b;
1128-
1129-
if (kcal->enabled)
1130-
sde_hw_kcal_pcc_adjust(data, i);
1131-
11321115
data[i + 12] = coeffs->rg;
11331116
data[i + 15] = coeffs->rb;
11341117
data[i + 18] = coeffs->gb;
@@ -1161,22 +1144,16 @@ void reg_dmav1_setup_dspp_pccv4(struct sde_hw_dspp *ctx, void *cfg)
11611144
if (rc)
11621145
DRM_ERROR("failed to kick off ret %d\n", rc);
11631146

1164-
if (kcal->enabled)
1165-
reg_dmav1_setup_dspp_pa_hsicv17_kcal(ctx, hw_cfg->ctl);
11661147
exit:
11671148
kfree(data);
11681149
}
11691150

11701151
void reg_dmav1_setup_dspp_pa_hsicv17(struct sde_hw_dspp *ctx, void *cfg)
11711152
{
11721153
struct sde_hw_cp_cfg *hw_cfg = cfg;
1173-
struct sde_hw_kcal *kcal = sde_hw_kcal_get();
11741154
u32 opcode = 0;
11751155
int rc;
11761156

1177-
if (kcal->enabled)
1178-
return;
1179-
11801157
opcode = SDE_REG_READ(&ctx->hw, ctx->cap->sblk->hsic.base);
11811158

11821159
rc = reg_dma_dspp_check(ctx, cfg, HSIC);

0 commit comments

Comments
 (0)