Skip to content

Commit 171dc07

Browse files
dbriemgmcharlt
authored andcommitted
LP#2131687 Holdings editor radio button UI syncs across fields
Bug: if multiple radio button fields are visible in the holdings editor, changes to one updates the UI of the others (the model is unaffected in the other fields, just their UI changes). This adds [name] to the radio button inputs so they bind to the expected input on RadioControlValueAccessor and group correctly. As per the helpful comment #6 on LP#2131687, we also need to keep the [attr.name] binding on these radio inputs because of Angular bug: angular/angular#11757. Signed-off-by: Dan Briem <[email protected]> Signed-off-by: Llewellyn Marshall <[email protected]> Signed-off-by: Galen Charlton <[email protected]>
1 parent ff21096 commit 171dc07

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
type="radio"
2323
class="form-check-input"
2424
id="{{field}}-input-{{option.value}}"
25+
[name]="field"
2526
[attr.name]="field"
2627
[value]="option.value"
2728
[(ngModel)]="values[field]"

0 commit comments

Comments
 (0)