LP2052742 Assure ou setting resolves before checking canSave()

emitSaveChange() calls canSave(), which checks the library setting cat.require_call_number_labels.

However, since the library setting check is asynchronous, there's a chance that we get to canSave()
before we have the library setting value, so it uses the default (true) instead.

This commit uses .then() to make sure that we only call emitSaveChange() after the library setting
promise resolves and we have the actual setting value, rather than the default.

Release-Note: Fixes a race condition retrieving the cat.require_call_number_labels ou setting

Co-authored-by: Michele Morgan <[email protected]>
Signed-off-by: Jane Sandberg <[email protected]>
Signed-off-by: Shula Link <[email protected]>
Signed-off-by: Steven Mayo <[email protected]>
Signed-off-by: blake <[email protected]>
Signed-off-by: Jason Stephenson <[email protected]>
Signed-off-by: Terran McCanna <[email protected]>

Author: 2 people

Open-ILS/src/eg2/src/app/staff/cat/volcopy/vol-edit.component.ts

@@ -93,28 +93,27 @@ export class VolEditComponent implements OnInit {
 
         this.volcopy.genBarcodesRequested.subscribe(() => this.generateBarcodes());
 
-        this.volcopy.fetchRecordVolLabels(this.context.recordId)
-            .then(labels => this.recordVolLabels = labels)
-            .then(_ => this.volcopy.fetchBibParts(this.context.getRecordIds()))
-            .then(_ => this.addStubCopies())
-        // It's possible the loaded data is not strictly allowed,
-        // e.g. empty string call number labels
-            .then(_ => this.emitSaveChange(true));
-
-        // Check to see if call number label is required
-        this.org.settings('cat.require_call_number_labels')
-            .then(settings => {
-                this.requireCNL =
-                Boolean(settings['cat.require_call_number_labels']);
-            });
-
         // Check for each org if a part is required
         for (const orgId of this.context.getOwningLibIds()) {
             this.org.settings('circ.holds.ui_require_monographic_part_when_present', orgId)
                 .then(settings => {
                     this.requirePartsOrgMap[orgId] = Boolean(settings['circ.holds.ui_require_monographic_part_when_present']);
                 });
         }
+
+        // Check to see if call number label is required
+        this.org.settings('cat.require_call_number_labels')
+            .then(settings => {
+                this.requireCNL =
+                Boolean(settings['cat.require_call_number_labels']);
+            })
+            .then(() => this.volcopy.fetchRecordVolLabels(this.context.recordId))
+            .then(labels => this.recordVolLabels = labels)
+            .then(_ => this.volcopy.fetchBibParts(this.context.getRecordIds()))
+            .then(_ => this.addStubCopies())
+        // It's possible the loaded data is not strictly allowed,
+        // e.g. empty string call number labels
+            .then(_ => this.emitSaveChange(true));
     }
 
     copyStatLabel(copy: IdlObject): string {