LP2089178 Restore OPAC Shelving Location filter

The #adv_copy_location_selector_new div was accidentally removed during
the accordion and fieldset refactoring done in bug 2048682. This patch
ensures that a fieldset with the required ID exists so that it can be
filled in by the render_adv_copy_locations_new() function in copyloc.js,
and adds a comment to alert future developers of the relationship.

Signed-off-by: Stephanie Leary <[email protected]>
Signed-off-by: Terran McCanna <[email protected]>

Author: stephanieleary

Open-ILS/src/templates-bootstrap/opac/parts/advanced/search.tt2

@@ -53,10 +53,10 @@
                     <summary class="card-header" id="[% adv_chunk.id %]_card">
                         <h4>[% adv_chunk.adv_label %]</h4>
                     </summary>
-
-                [% IF adv_chunk.id != 'adv_copy_location_selector';%]
-                <fieldset class="card-body" aria-labelledby="[% adv_chunk.id %]_card">
-                [% END %]
+                
+                [% # Note: #adv_copy_location_selector_new is required by web/js/ui/default/opac/copyloc.js %]
+                <fieldset class="card-body" aria-labelledby="[% adv_chunk.id %]_card"
+                    id="[% IF adv_chunk.id == 'adv_copy_location_selector'; 'adv_copy_location_selector_new';  ELSE; adv_chunk.id; END; %]">
                         [% IF adv_chunk.adv_attr;
                                     INCLUDE "opac/parts/check_value_selector.tt2"
                                         id=adv_chunk.id
@@ -68,9 +68,7 @@
                                         filter_group=adv_chunk.adv_filter multiple="multiple"
                                         size=adv_chunk.adv_size || search.default_adv_select_height || "4";
                         END; %]
-                        
                 </fieldset>
-                
             </details>
 
         </div>

Open-ILS/web/js/ui/default/opac/copyloc.js

@@ -96,7 +96,7 @@ function render_adv_copy_locations_new(locations) {
 
         ulist.appendChild(dojo.create('li')).appendChild(dojo.create('div', {class: "form-check"})).appendChild(dojo.create('label', {innerHTML : loc.name, class: "form-check-label"})).prepend(dojo.create('input', attrs));
     });
-    sel.appendChild(dojo.create("div", {class: "card-body"})).appendChild(ulist);}
+    sel.appendChild(ulist);}
 }