LP#2110908: Repair SR clone/edit special case

We handle org_unit-type columns specially in the reporter, because
there's a bunch of implicit logic regarding hierarchy and widgets.  Due
to that, we need to be careful when loading a saved template that we
have not already performed a particular internal transformation on the
data we are about to store.  This commit checks for that and avoids
doubling the special-case encoding for filters on these columns.

Release-note: Fix Simple Report cloning and editing when using
a filter on an organizational unit

Signed-off-by: Mike Rylander <[email protected]>
Signed-off-by: Galen Charlton <[email protected]>

Author: spaceisntsyntax

Open-ILS/src/eg2/src/app/staff/reporter/share/reporter.service.ts

@@ -1190,7 +1190,7 @@ export class ReporterService {
         templ.filterFields.forEach((el, idx) => {
             if (isSimple || !el.with_value_input) {
                 rrData[el.filter_placeholder] = el.force_filtervalues ? el.force_filtervalues : el.filter_value;
-                if (el.datatype === 'org_unit' && el.operator.name === '= any') { // special case for org selector
+                if (typeof rrData[el.filter_placeholder] === 'string' && el.datatype === 'org_unit' && el.operator.name === '= any') { // special case for org selector
                     const final_value = { transform: 'Bare', params: rrData[el.filter_placeholder] };
                     final_value['_org_family_primaryOrgId'] = el._org_family_primaryOrgId;
                     final_value['_org_family_includeAncestors'] = el._org_family_includeAncestors;