LP#2110907 Staff Portal Links Open in New Tab

Remove ES6 syntax in the AngularJS target service and directive
to retain UglifyJS compatibility when building for production.

Signed-off-by: Dan Briem <[email protected]>
Signed-off-by: Jane Sandberg <[email protected]>
Signed-off-by: blake <[email protected]>
Signed-off-by: Terran McCanna <[email protected]>
Signed-off-by: Michele Morgan <[email protected]>

Author: dbriem

Open-ILS/web/js/ui/default/staff/services/ui.js

@@ -1691,8 +1691,8 @@ https://stackoverflow.com/questions/24764802/angular-js-automatically-focus-inpu
 .factory('egLinkTargetService', ['egCore', function(egCore) {
     const newTabsDisabledKey = 'ui.staff.disable_links_newtabs';
 
-    let initSettingLoaded = false;
-    let firstSharedResponse = null;
+    var initSettingLoaded = false;
+    var firstSharedResponse = null;
 
     function getSetting() {
         return egCore.hatch.getItem(newTabsDisabledKey);
@@ -1710,7 +1710,7 @@ https://stackoverflow.com/questions/24764802/angular-js-automatically-focus-inpu
         // share first Promise to avoid multiple server requests
         if (!initSettingLoaded) {
             if (!firstSharedResponse) {
-                firstSharedResponse = getSetting().finally(() => {
+                firstSharedResponse = getSetting().finally(function() {
                     initSettingLoaded = true;
                 });
             }
@@ -1721,7 +1721,11 @@ https://stackoverflow.com/questions/24764802/angular-js-automatically-focus-inpu
         return getSetting();
     }
 
-    return { disableNewTabs, enableNewTabs, newTabsDisabled };
+    return {
+        disableNewTabs: disableNewTabs,
+        enableNewTabs: enableNewTabs,
+        newTabsDisabled: newTabsDisabled
+    };
 }])
 
 /**
@@ -1757,7 +1761,7 @@ https://stackoverflow.com/questions/24764802/angular-js-automatically-focus-inpu
                 if (SAME_TAB_TARGETS.has(attrs.target)) { return; }
 
                 egLinkTargetService.newTabsDisabled()
-                    .then(disabled => {
+                    .then(function(disabled) {
                         if (disabled) {
                             elem.attr('target', null);
                         } else {