Skip to content

Commit 8642ffa

Browse files
stephanielearygmcharlt
authored andcommitted
LP2102739 Staff banner H1 & ID for link checker
Updates the markup of the staff banner in the link checker batch attempts and sessions grids, which can't use the eg-staff-banner component due to Angular's shortcomings with ICU expressions in attributes. This corrects the styling of the page heading and allows the skip navigation link to work as expected. Release-note: Fix title styling, skip link destination in link checker Signed-off-by: Stephanie Leary <[email protected]> Signed-off-by: Llewellyn Marshall <[email protected]> Signed-off-by: Galen Charlton <[email protected]>
1 parent ba9d613 commit 8642ffa

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Open-ILS/src/eg2/src/app/staff/cat/linkchecker/attempts.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<!-- how should we do i18n with eg-staff-banner? -->
2-
<div class="lead alert alert-primary text-center pt-1 pb-1">
3-
<span class="align-middle">
4-
{batches, plural, =0 {Attempts for All Batches} =1 {Attempts for Batch ID {{batches}}} other {Attempts for Batch IDs {{batches}}}}
5-
</span>
2+
<div class="staff-banner">
3+
<h1 id="staff-banner" tabindex="-1">
4+
<span i18n>{batches, plural, =0 {Attempts for All Batches} =1 {Attempts for Batch ID {{batches}}} other {Attempts for Batch IDs {{batches}}}}</span>
5+
</h1>
66
</div>
77

88
<ng-template #bibIdTemplate let-r="row">

Open-ILS/src/eg2/src/app/staff/cat/linkchecker/urls.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<!-- how should we do i18n with eg-staff-banner? -->
2-
<div class="lead alert alert-primary text-center pt-1 pb-1">
3-
<span class="align-middle">
4-
{session_names, plural, =0 {URLs for All Sessions} =1 {URLs for Session: {{session_names.join(', ')}}} other {URLs for Sessions: {{session_names.join(', ')}}}}
5-
</span>
2+
<div class="staff-banner">
3+
<h1 id="staff-banner" tabindex="-1">
4+
<span i18n>{session_names, plural, =0 {URLs for All Sessions} =1 {URLs for Session: {{session_names.join(', ')}}} other {URLs for Sessions: {{session_names.join(', ')}}}}</span>
5+
</h1>
66
</div>
77

88
<ng-template #bibIdTemplate let-r="row">

0 commit comments

Comments
 (0)