fix: pack one binary per platform into python wheels

Author: danfimov

packaging/pack.rb

@@ -9,6 +9,10 @@
 ROOT = File.join(__dir__, "..")
 DIST = File.join(ROOT, "dist")
 
+OPERATING_SYSTEMS = ["linux", "darwin", "freebsd", "openbsd", "windows"]
+ARCHITECTURES = ["x86_64", "arm64"]
+PLATFORMS = OPERATING_SYSTEMS.product(ARCHITECTURES).map { |os, arch| { os: os, arch: arch } }
+
 module Pack
   extend FileUtils
 
@@ -164,8 +168,24 @@ def publish_gem
 
   def publish_pypi
     puts "Publishing to PyPI..."
-    cd(File.join(__dir__, "pypi"))
-    system("python setup.py sdist bdist_wheel", exception: true)
+    pypi_dir = File.join(__dir__, "pypi")
+
+    puts "Building source distribution..."
+    cd(pypi_dir)
+    system("python setup.py sdist", exception: true)
+
+    PLATFORMS.each do |platform|
+      puts "Building wheel for #{platform[:os]}-#{platform[:arch]}..."
+      env = {
+        "LEFTHOOK_TARGET_PLATFORM" => platform[:os],
+        "LEFTHOOK_TARGET_ARCH" => platform[:arch]
+      }
+
+      cd(pypi_dir)
+      system(env, "python setup.py bdist_wheel", exception: true)
+    end
+
+    cd(pypi_dir)
     system("python -m twine upload --verbose --repository lefthook dist/*", exception: true)
   end
 

packaging/pypi/setup.py

@@ -1,8 +1,63 @@
+import os
+import sys
+import platform
 from setuptools import setup, find_packages
+from wheel.bdist_wheel import bdist_wheel as _bdist_wheel
 
 with open("README.md", "r") as fh:
     long_description = fh.read()
 
+# Map Python's platform names to our binary folder names
+PLATFORM_MAPPING = {
+    'linux': 'linux',
+    'darwin': 'darwin',
+    'win32': 'windows',
+    'freebsd': 'freebsd',
+    'openbsd': 'openbsd',
+}
+
+ARCH_MAPPING = {
+    'x86_64': 'x86_64',
+    'AMD64': 'x86_64',
+    'amd64': 'x86_64',
+    'aarch64': 'arm64',
+    'arm64': 'arm64',
+}
+
+def get_platform_info():
+    """Determine the platform and architecture from environment or system."""
+    target_platform, target_architecture = os.environ.get('LEFTHOOK_TARGET_PLATFORM'), os.environ.get('LEFTHOOK_TARGET_ARCH')
+
+    if target_platform and target_architecture:
+        return target_platform, target_architecture
+
+    system, machine = platform.system().lower(), platform.machine().lower()
+    return PLATFORM_MAPPING.get(sys.platform, system), ARCH_MAPPING.get(machine, machine)
+
+class CustomBdistWheel(_bdist_wheel):
+    """Custom bdist_wheel that generates platform-specific wheels."""
+
+    def finalize_options(self):
+        """Initialize platform-specific options."""
+        super().finalize_options()
+        platform, architecture = get_platform_info()
+        self.plat_name = f"{platform}_{architecture}"
+
+    def get_tag(self):
+        """Override to return platform-specific tag."""
+        platform, architecture = get_platform_info()
+        return ('py3', 'none', f'{platform}_{architecture}')
+
+def get_package_data():
+    """Get only the binary for the current/target platform."""
+    platform, architecture = get_platform_info()
+    binary_name = 'lefthook'
+    if platform == 'windows':
+        binary_name = 'lefthook.exe'
+    return {
+        'lefthook': [f'bin/lefthook-{platform}-{architecture}/{binary_name}']
+    }
+
 setup(
     name='lefthook',
     version='2.0.2',
@@ -18,22 +73,12 @@
             'lefthook=lefthook.main:main'
         ],
     },
-    package_data={
-        'lefthook':[
-            'bin/lefthook-linux-x86_64/lefthook',
-            'bin/lefthook-linux-arm64/lefthook',
-            'bin/lefthook-freebsd-x86_64/lefthook',
-            'bin/lefthook-freebsd-arm64/lefthook',
-            'bin/lefthook-openbsd-x86_64/lefthook',
-            'bin/lefthook-openbsd-arm64/lefthook',
-            'bin/lefthook-windows-x86_64/lefthook.exe',
-            'bin/lefthook-windows-arm64/lefthook.exe',
-            'bin/lefthook-darwin-x86_64/lefthook',
-            'bin/lefthook-darwin-arm64/lefthook',
-        ]
+    package_data=get_package_data(),
+    license_files=['LICENSE'],
+    cmdclass={
+        'bdist_wheel': CustomBdistWheel,
     },
     classifiers=[
-        'License :: OSI Approved :: MIT License',
         'Operating System :: OS Independent',
         'Topic :: Software Development :: Version Control :: Git'
     ],