Skip to content

Commit 322cb42

Browse files
authored
🐛 FIX NoURI error in doc reference resolution (#734)
1 parent 585ce9a commit 322cb42

File tree

6 files changed

+21
-13
lines changed

6 files changed

+21
-13
lines changed

myst_parser/sphinx_ext/myst_refs.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,12 @@ def resolve_myst_ref_doc(self, node: pending_xref):
178178
)
179179

180180
assert self.app.builder
181-
ref_node = make_refnode(
182-
self.app.builder, from_docname, ref_docname, targetid, innernode
183-
)
181+
try:
182+
ref_node = make_refnode(
183+
self.app.builder, from_docname, ref_docname, targetid, innernode
184+
)
185+
except NoUri:
186+
ref_node = innernode
184187
node.replace_self(ref_node)
185188

186189
def resolve_myst_ref_any(

tests/test_sphinx/sourcedirs/texi_table/index.md

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
orphan: true
3+
---
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
Check that NoURIError is handled correctly:
2+
3+
[](file.md)
4+
5+
Check that tables can be built:
6+
7+
| foo | bar |
8+
| --- | --- |
9+
| baz | bim |

tests/test_sphinx/test_sphinx_builds.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -564,15 +564,11 @@ def test_fieldlist_extension(
564564

565565
@pytest.mark.sphinx(
566566
buildername="texinfo",
567-
srcdir=os.path.join(SOURCE_DIR, "texi_table"),
567+
srcdir=os.path.join(SOURCE_DIR, "texinfo"),
568568
freshenv=True,
569569
)
570-
def test_texinfo_table(
571-
app,
572-
status,
573-
warning,
574-
):
575-
"""Test that tables can be built with the Texinfo builder."""
570+
def test_texinfo(app, status, warning):
571+
"""Test Texinfo builds."""
576572
app.build()
577573
assert "build succeeded" in status.getvalue() # Build succeeded
578574
warnings = warning.getvalue().strip()

0 commit comments

Comments
 (0)