Skip to content

Commit 62e41a5

Browse files
ErikSchierboomrobkeim
authored andcommitted
Use property to retrieve balance in bank-account exercise (#192)
1 parent 3b76019 commit 62e41a5

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

exercises/bank-account/BankAccountTest.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public void Returns_empty_balance_after_opening()
1111
var account = new BankAccount();
1212
account.Open();
1313

14-
Assert.That(account.GetBalance(), Is.EqualTo(0));
14+
Assert.That(account.Balance, Is.EqualTo(0));
1515
}
1616

1717
[Ignore("Remove to run test")]
@@ -21,10 +21,10 @@ public void Check_basic_balance()
2121
var account = new BankAccount();
2222
account.Open();
2323

24-
var openingBalance = account.GetBalance();
24+
var openingBalance = account.Balance;
2525

2626
account.UpdateBalance(10);
27-
var updatedBalance = account.GetBalance();
27+
var updatedBalance = account.Balance;
2828

2929
Assert.That(openingBalance, Is.EqualTo(0));
3030
Assert.That(updatedBalance, Is.EqualTo(10));
@@ -36,13 +36,13 @@ public void Balance_can_increment_and_decrement()
3636
{
3737
var account = new BankAccount();
3838
account.Open();
39-
var openingBalance = account.GetBalance();
39+
var openingBalance = account.Balance;
4040

4141
account.UpdateBalance(10);
42-
var addedBalance = account.GetBalance();
42+
var addedBalance = account.Balance;
4343

4444
account.UpdateBalance(-15);
45-
var subtractedBalance = account.GetBalance();
45+
var subtractedBalance = account.Balance;
4646

4747
Assert.That(openingBalance, Is.EqualTo(0));
4848
Assert.That(addedBalance, Is.EqualTo(10));
@@ -57,7 +57,7 @@ public void Closed_account_throws_exception_when_checking_balance()
5757
account.Open();
5858
account.Close();
5959

60-
Assert.Throws<InvalidOperationException>(() => account.GetBalance());
60+
Assert.That(() => account.Balance, Throws.InvalidOperationException);
6161
}
6262

6363
[Ignore("Remove to run test")]
@@ -84,6 +84,6 @@ public void Change_account_balance_from_multiple_threads()
8484
}
8585
Task.WaitAll(tasks.ToArray());
8686

87-
Assert.That(account.GetBalance(), Is.EqualTo(0));
87+
Assert.That(account.Balance, Is.EqualTo(0));
8888
}
8989
}

exercises/bank-account/Example.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,19 @@ public void Close()
2323
}
2424
}
2525

26-
public float GetBalance()
26+
public float Balance
2727
{
28-
lock(_lock)
28+
get
2929
{
30-
if (!isOpen)
30+
lock (_lock)
3131
{
32-
throw new InvalidOperationException("Cannot get balance on an account that isn't open");
33-
}
32+
if (!isOpen)
33+
{
34+
throw new InvalidOperationException("Cannot get balance on an account that isn't open");
35+
}
3436

35-
return balance;
37+
return balance;
38+
}
3639
}
3740
}
3841

0 commit comments

Comments
 (0)