Skip to content

Commit 9c2b193

Browse files
Merge pull request #768 from robkeim/triangle-exception
Remove unushed exception in Triangle exercise
2 parents 0bd0462 + 8c79d4d commit 9c2b193

4 files changed

Lines changed: 4 additions & 10 deletions

File tree

exercises/bowling/BowlingTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public void Cannot_roll_after_bonus_rolls_for_strike()
291291
Assert.Throws<ArgumentException>(() => sut.Roll(2));
292292
}
293293

294-
public void DoRoll(IEnumerable<int> rolls, BowlingGame sut)
294+
private void DoRoll(IEnumerable<int> rolls, BowlingGame sut)
295295
{
296296
foreach (var roll in rolls)
297297
{

exercises/triangle/Example.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ public enum TriangleKind
1111

1212
public static class Triangle
1313
{
14-
1514
public static bool IsScalene(double side1, double side2, double side3)
1615
{
1716
return Kind(side1, side2, side3) == TriangleKind.Scalene;
@@ -65,6 +64,4 @@ private static int UniqueSides(double side1, double side2, double side3)
6564
double[] sides = { side1, side2, side3 };
6665
return sides.Distinct().Count();
6766
}
68-
}
69-
70-
public class TriangleException : Exception { }
67+
}

exercises/triangle/Triangle.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,4 @@ public static bool IsEquilateral(double side1, double side2, double side3)
1616
{
1717
throw new NotImplementedException("You need to implement this function.");
1818
}
19-
20-
}
21-
22-
public class TriangleException : Exception { }
19+
}

generators/Exercises/Generators/Bowling.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected override void UpdateTestClass(TestClass testClass)
7878
private static void AddDoRollMethod(TestClass testClass)
7979
{
8080
testClass.AdditionalMethods.Add(@"
81-
public void DoRoll(IEnumerable<int> rolls, BowlingGame sut)
81+
private void DoRoll(IEnumerable<int> rolls, BowlingGame sut)
8282
{
8383
foreach (var roll in rolls)
8484
{

0 commit comments

Comments
 (0)