Skip to content

Move enumerations to outer scope #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ErikSchierboom opened this issue Feb 15, 2017 · 0 comments · Fixed by #199
Closed

Move enumerations to outer scope #204

ErikSchierboom opened this issue Feb 15, 2017 · 0 comments · Fixed by #199
Assignees

Comments

@ErikSchierboom
Copy link
Member

Currently, all code is compiled in a single DLL. This caused some namespacing issues, which could be solves by moving enumeration declarations within a class. An example of this is the go-counting exercise:

public class GoCounting
{
    public enum Player
    {
        None,
        Black,
        White
    }

With the #199 PR being worked on, each exercise will have its own solution. The namespacing workaround mentioned above is no longer necessary, so we can (and should) move the inner types to the outer namespace:

public enum Player
{
    None,
    Black,
    White
}

public class GoCounting
{
}

Note: this requires #199 to be merged before we can continue.

@ErikSchierboom ErikSchierboom self-assigned this Feb 20, 2017
@ErikSchierboom ErikSchierboom changed the title Move enumerations to outer scope [WIP] Move enumerations to outer scope Feb 21, 2017
@ErikSchierboom ErikSchierboom changed the title [WIP] Move enumerations to outer scope Move enumerations to outer scope Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant