Skip to content

Add ETL Test Generator #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpreese opened this issue Sep 6, 2017 · 4 comments
Closed

Add ETL Test Generator #409

jpreese opened this issue Sep 6, 2017 · 4 comments

Comments

@jpreese
Copy link
Contributor

jpreese commented Sep 6, 2017

This issue is part of an overall initiative to complete #195.

The documentation on how to add generators can be found here. If you get stuck or have any questions about adding this generator, please do not hesitate to reach out!

@hymccord
Copy link
Contributor

hymccord commented Oct 4, 2017

I've started on this one.

@hymccord
Copy link
Contributor

hymccord commented Oct 4, 2017

I've run into a design decision. The input from the canonical-data is of type IDictionary<int,IList<string>> which switches to default: in the ValueFormatter class. Would it be helpful to add this to the ValueFormatter class or do I just write some methods in the generator class that formats it for me while Arranging?

If wanted in ValueFormatter I think I will also need to add a FormatMultilineEnumerable method that doesn't output a variable name like the current one.

@ErikSchierboom
Copy link
Member

@inkahootz Well, good point. It may be easier to just do the formatting in the generator class itself. We can always refactor to another method if needed later.

@ErikSchierboom
Copy link
Member

Closed by #462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants