Skip to content

Add Two Bucket Test Generator #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpreese opened this issue Sep 6, 2017 · 5 comments
Closed

Add Two Bucket Test Generator #424

jpreese opened this issue Sep 6, 2017 · 5 comments

Comments

@jpreese
Copy link
Contributor

jpreese commented Sep 6, 2017

This issue is part of an overall initiative to complete #195.

The documentation on how to add generators can be found here. If you get stuck or have any questions about adding this generator, please do not hesitate to reach out!

@GKotfis
Copy link
Contributor

GKotfis commented Sep 29, 2017

I'll deal with it.

@GKotfis
Copy link
Contributor

GKotfis commented Sep 29, 2017

Question about file & class names. Exercise, project name and canonical-data are "TwoBucket". But class name in exercise is "TwoBuckets. As I see generator use class name also for finding canonical-data and here is the problem. The quickest option will be to change class name in exercise to TwoBucket?

@jpreese
Copy link
Contributor Author

jpreese commented Sep 30, 2017

@GKotfis yep! Feel free to update the existing class. This case is specifically outlined in the provided generators documentation :)

@robkeim
Copy link
Contributor

robkeim commented Sep 30, 2017

@GKotfis for some historical context, when this project started we didn't have any canonical data so each of the different tracks had a lot of liberty in their implementations (naming, what they tested, etc).

Now we're trying to standardize to have a more consistent experience across tracks which is great, but we're trying to retrofit our existing solutions into the generators. For some exercises it's very straightforward but other exercises need a larger refactoring.

@ErikSchierboom
Copy link
Member

Fixed by #447.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants