Skip to content

Procedure to propose a rename an exercise? #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masters3d opened this issue Apr 25, 2016 · 9 comments
Closed

Procedure to propose a rename an exercise? #12

masters3d opened this issue Apr 25, 2016 · 9 comments

Comments

@masters3d
Copy link

masters3d commented Apr 25, 2016

Is there a current way to suggest a change of name for an exercise ?

For example:
https://github.com/exercism/x-common/blob/master/perfect-numbers.md
should probably be called number-classifier because perfect is one of the classifications.
It doesn't make sense to call a solution perfect number because that is not the only output.

https://github.com/exercism/x-common/blob/master/robot-name.md
I don't like that the name of this exercise contains the word name. Why not just robot?
Or robot-manager?

Edit: specific names:

@kotp
Copy link
Member

kotp commented Apr 25, 2016

I noticed that the wiki is in place, and x-common is where the change would be affected. Perhaps a process for name changes could be documented there?

It is actually nice to have the wiki there to document the 'meta' things, as you can clone it in the project structure, ignore wiki/ in your global excludes file for git and have it close at hand with or without network access, fully searchable, etc.

As to the suggested name changes, I don't think introducing case in the names makes sense, some file systems do not distinguish case for file names, and others do, so it introduces "another thing" to manage. Of course, I am matching your supplied "NumberClassifier" to your explicit example of master/perfect-numbers.md so assuming you mean something like master/NumberClassifier.md as the change.

@kotp kotp added the question label Apr 25, 2016
@masters3d
Copy link
Author

I didn't mean to suggest a new format just the content. number-classifier works

@kytrinyx
Copy link
Member

How about sticking the instructions in the Contributing Guide once we come up with a procedure?

If the wiki is there, it's probably because I forgot to uncheck the box when I created the repo. I don't want yet another place to have to look--things are already so spread out as they are.

I agree that we shouldn't change the format; all-lowercase with hyphens is a format that works.

Name changes are kind of complicated at the moment, because the submission data depends on the problem slug. If we change the name then:

  • old submissions should be renamed in the database so that they show up when you browse the exercise using the new name
  • people who have submitted the exercise under the old name should not be given the exercise under the new name when they fetch
  • people who submitted the exercise under the old name should be able to see and comment on the same exercise under the new name

There might be other things as well, which we would probably only discover the first time we do this.

@petertseng
Copy link
Member

Anything we learned from deprecating point-mutations in favor of hamming that we could apply here?

@kytrinyx
Copy link
Member

Yeah, that's what I was digging through my medium-term memory to attempt to retrieve. Those three points are what came to mind.

@IanWhitney
Copy link

@petertseng

I saw one student in Rust who seemed confused by the name change. I figure they saw it in another track under the old name and wondered why Rust had a new name. It didn't cause any problems, just a question.

@kytrinyx
Copy link
Member

kytrinyx commented Jun 21, 2016

see also #40 which is a more generalized case of this.

@kytrinyx kytrinyx reopened this Jun 21, 2016
@kytrinyx
Copy link
Member

kytrinyx commented Jul 6, 2016

We have some dirty data here: exercism/scheme#44

@kytrinyx
Copy link
Member

kytrinyx commented Jun 5, 2017

I've read through this issue a couple of times and I'm not sure whether this discussion is attempting to decide whether we should change the name of specific exercises, or decide what the process is in general.

It almost looks like it started as one and morphed into another.

So—in order to clarify things, I'm opening a new issue only to brainstorm how to safely perform a "rename exercise" procedure: #156

If you want to suggest that we rename specific exercises, @masters3d, please open an issue for each exercise so that we can discuss the problems with the name as well as possible alternatives.

@kytrinyx kytrinyx closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants