Skip to content

Beer Song - Remove stub solution #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpalma opened this issue Mar 22, 2017 · 5 comments
Closed

Beer Song - Remove stub solution #510

lpalma opened this issue Mar 22, 2017 · 5 comments

Comments

@lpalma
Copy link
Contributor

lpalma commented Mar 22, 2017

I'm not sure why Beer Song has a stub solution, which is basically a copy of the test, making it pass.

Shouldn't it follow the standard error "You need to implement this function." found in other exercises? The test and the README already provide the lyrics, so I don't think it is necessary to also have it in the src code.

@petertseng
Copy link
Member

petertseng commented Mar 22, 2017

I'm not sure why Beer Song has a stub solution

because https://github.com/exercism/xhaskell/blob/master/exercises/beer-song/HINTS.md and #301

let us know if you disagree

@lpalma
Copy link
Contributor Author

lpalma commented Mar 22, 2017

because https://github.com/exercism/xhaskell/blob/master/exercises/beer-song/HINTS.md and #301

oh... my bad. I should have paid more attention in the README. It makes sense now.

Actually this brought me another question, and I hope I'm not being pedantic here 😛

Not all exercises have Hints, but all of them have the basic instruction sections Getting Started, Running the tests, etc. right after the problem description (or For bonus points, when available).

Shouldn't Hints be displayed before these instructions sections and after the problem description? Most of the students (or is it just me? 😕 ) would read those instruction sections only once and ignore them on the following exercises, not realising there maybe be more important information after that.

In other words, instruction sections are static/invariant, thus shouldn't be followed by anything.

Is it a question that should be asked in x-common instead?

@petertseng
Copy link
Member

Shouldn't Hints be displayed before these instructions sections and after the problem description?
Is it a question that should be asked in x-common instead?

Probably, since it relates to more tracks than just Haskell.

The change will need to be made in https://github.com/exercism/trackler/blob/master/lib/trackler/implementation.rb , though opening the issue in trackler repository will probably not reach enough of an audience.

@petertseng
Copy link
Member

In other words, instruction sections are static/invariant, thus shouldn't be followed by anything.

This makes sense to me. Right now, the order is:

  • part specific to each exercise
  • part not specific to each exercise
  • part specific to each exercise

@lpalma
Copy link
Contributor Author

lpalma commented Mar 23, 2017

The change will need to be made in https://github.com/exercism/trackler/blob/master/lib/trackler/implementation.rb

thanks @petertseng
It's good to know where things belong / how they are glued together :-)

I have opened the Issue in Trackler. Hopefully feedback will be given.

Edit: That said, and considering that Beer Song is fine, I think this Issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants