queen-attack: Rewrite tests to use hspec with fail-fast. #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite tests to use `hspec`. - Update `canAttack` tests to match `x-common` - Suppress test suite warning on polymorphic solutions.
|
👍 , I'll defer to others' judgments on the JSON file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hspec.canAttacktests to matchx-commonRelated to #211.
The exercise matches only partially the JSON file, because it doesn't have a functions to create queens. That function would probably make more sense in a object-oriented language, but seems artificial here.
Also, the coordinate system used is artificial for chess players. Maybe the JSON file deserves a rewrite to remove the
createfunction and use a right-up orientation starting on (1, 1), as explained in this comment.