Skip to content

nucleotide-count: Use data type to represent nucleotides #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2018
Merged

nucleotide-count: Use data type to represent nucleotides #714

merged 2 commits into from
Sep 10, 2018

Conversation

sshine
Copy link
Contributor

@sshine sshine commented Sep 8, 2018

Preserve the Data.Map.

References #694

@petertseng
Copy link
Member

I see, so not changing the entire input, just the outputs.

You need to use a word from https://help.github.com/articles/closing-issues-using-keywords/, not "References". Please do that.

@petertseng
Copy link
Member

petertseng commented Sep 10, 2018

References #964

doesn't exist. it's 694. (so please fix to use correct issue number)

Preserve the Data.Map.

Fixes #694
@sshine
Copy link
Contributor Author

sshine commented Sep 10, 2018

@petertseng With a few tries, I've addressed both issues.

And yes, I figured accepting broken strings was in the spirit of the assignment, like broken DNA. :-)

@petertseng petertseng changed the title Use data type to represent nucleotides nucleotide-count: Use data type to represent nucleotides Sep 10, 2018
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic! let's get this merged (as soon as tests pass)!

I just remembered that this wants a version increase (it's documented-as-undocumented in #538), so I'll add it. Wouldn't want to hold this up over that.

@petertseng petertseng merged commit a5d65fe into exercism:master Sep 10, 2018
@petertseng
Copy link
Member

Very good, thank you!

@sshine sshine deleted the nucleotide-count branch September 10, 2018 13:18
@sshine
Copy link
Contributor Author

sshine commented Dec 7, 2018

Three months later, giving my first review writing mentor notes to this exercise and realizing my own version doesn't have the data Nucleotide definition, I ask myself: "Who the hell added this in the meantime?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants