Skip to content

binary-search-tree: add angle brackets when calling constructor #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FridaTveit opened this issue Jul 12, 2017 · 5 comments
Closed

binary-search-tree: add angle brackets when calling constructor #700

FridaTveit opened this issue Jul 12, 2017 · 5 comments

Comments

@FridaTveit
Copy link
Contributor

Since the BST class uses generics it should be constructed using angle brackets. For example:

BST<Integer> binarySearchTree = new BST<>();

This is done sometimes in BSTTest but not always. It should be done everywhere where a BST object is created in BSTTest.

@FridaTveit FridaTveit added code good first issue Good for newcomers labels Jul 12, 2017
@stkent
Copy link
Contributor

stkent commented Jul 12, 2017

(Reminder that this exercise is pending review for use of generics per #230 also.)

@ribhav-pahuja
Copy link

@FridaTveit , I would like to contribute to this.

@Smarticles101
Copy link
Member

@ribhav-pahuja Feel free to tackle this! 👍

@FridaTveit
Copy link
Contributor Author

Yes, like @Smarticles101 said, feel free to work on it :)

@FridaTveit
Copy link
Contributor Author

Fixed in PR #842. Thanks @szielinski! :)

I'm sorry if you were still working on it @ribhav-pahuja. I forgot about your comment when merging the PR, sorry. There should be lots of other good-first-patch issues you can work on though. Let me know if you have any problems finding any :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants