Skip to content

Use airbnb-eslint config #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tejasbubane opened this issue May 22, 2019 · 1 comment · Fixed by #1094
Closed

Use airbnb-eslint config #681

tejasbubane opened this issue May 22, 2019 · 1 comment · Fixed by #1094
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc.

Comments

@tejasbubane
Copy link
Member

From #645

Turn on airbnb-base for maintaining via a script that switches this.

In a later change, we should turn on several rules that guard against potential bugs, such as no-shadow, no-undefined, no-var; additionally we can add stylistic consistency without forcing style choises such as consistent spacing (but not required).

We should stay with eslint:recommended for exercises (end users) and use airbnb only for this repo. @SleeplessByte

Wait for #680 to be merged so that we can exclude airbnb from package.json checksum CI task.
@tejasbubane tejasbubane added the chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. label May 22, 2019
@tejasbubane tejasbubane changed the title Use airbnb-eslint plugin Use airbnb-eslint config May 22, 2019
@SleeplessByte
Copy link
Member

Yes yes yes! This is exactly what I meant.

@SleeplessByte SleeplessByte mentioned this issue May 29, 2019
Closed
@SleeplessByte SleeplessByte mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linting overhaul exercism/javascript
2 participants
@tejasbubane @SleeplessByte