Skip to content

Commit 55c0c6f

Browse files
committed
Fix triangle sides showing up in test name
1 parent 96e97e3 commit 55c0c6f

File tree

2 files changed

+20
-12
lines changed

2 files changed

+20
-12
lines changed

exercises/triangle/.meta/generator/triangle_case.rb

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,19 @@ def indent(line)
2424
end
2525

2626
def failure_message
27-
%Q("Expected '#{expected}', #{expected_type}.")
27+
%Q("Expected '#{expected}', #{expected_triangle}.")
2828
end
2929

3030
def expected_type
31-
"triangle #{sides} is #{expected ? '' : 'not '}#{property}"
31+
"triangle is #{type}"
32+
end
33+
34+
def expected_triangle
35+
"triangle #{sides} is #{type}"
36+
end
37+
38+
def type
39+
"#{expected ? '' : 'not ' }#{property}"
3240
end
3341

3442
end

exercises/triangle/triangle_test.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@
44

55
# Common test data version: 1.0.0 fa90b35
66
class TriangleTest < Minitest::Test
7-
def test_triangle_[2_2_2]_is_equilateral_if_all_sides_are_equal
7+
def test_triangle_is_equilateral_if_all_sides_are_equal
88
# skip
99
triangle = Triangle.new([2, 2, 2])
1010
assert triangle.equilateral?, "Expected 'true', triangle [2, 2, 2] is equilateral."
1111
end
1212

13-
def test_triangle_[2_3_2]_is_not_equilateral_if_any_side_is_unequal
13+
def test_triangle_is_not_equilateral_if_any_side_is_unequal
1414
skip
1515
triangle = Triangle.new([2, 3, 2])
1616
refute triangle.equilateral?, "Expected 'false', triangle [2, 3, 2] is not equilateral."
1717
end
1818

19-
def test_triangle_[5_4_6]_is_not_equilateral_if_no_sides_are_equal
19+
def test_triangle_is_not_equilateral_if_no_sides_are_equal
2020
skip
2121
triangle = Triangle.new([5, 4, 6])
2222
refute triangle.equilateral?, "Expected 'false', triangle [5, 4, 6] is not equilateral."
@@ -34,19 +34,19 @@ def test_equilateral_triangle_sides_may_be_floats
3434
assert triangle.equilateral?, "Expected 'true', triangle [0.5, 0.5, 0.5] is equilateral."
3535
end
3636

37-
def test_triangle_[3_4_4]_is_isosceles_if_last_two_sides_are_equal
37+
def test_triangle_is_isosceles_if_last_two_sides_are_equal
3838
skip
3939
triangle = Triangle.new([3, 4, 4])
4040
assert triangle.isosceles?, "Expected 'true', triangle [3, 4, 4] is isosceles."
4141
end
4242

43-
def test_triangle_[4_4_3]_is_isosceles_if_first_two_sides_are_equal
43+
def test_triangle_is_isosceles_if_first_two_sides_are_equal
4444
skip
4545
triangle = Triangle.new([4, 4, 3])
4646
assert triangle.isosceles?, "Expected 'true', triangle [4, 4, 3] is isosceles."
4747
end
4848

49-
def test_triangle_[4_3_4]_is_isosceles_if_first_and_last_sides_are_equal
49+
def test_triangle_is_isosceles_if_first_and_last_sides_are_equal
5050
skip
5151
triangle = Triangle.new([4, 3, 4])
5252
assert triangle.isosceles?, "Expected 'true', triangle [4, 3, 4] is isosceles."
@@ -58,7 +58,7 @@ def test_equilateral_triangles_are_also_isosceles
5858
assert triangle.isosceles?, "Expected 'true', triangle [4, 4, 4] is isosceles."
5959
end
6060

61-
def test_triangle_[2_3_4]_is_not_isosceles_if_no_sides_are_equal
61+
def test_triangle_is_not_isosceles_if_no_sides_are_equal
6262
skip
6363
triangle = Triangle.new([2, 3, 4])
6464
refute triangle.isosceles?, "Expected 'false', triangle [2, 3, 4] is not isosceles."
@@ -76,19 +76,19 @@ def test_isosceles_triangle_sides_may_be_floats
7676
assert triangle.isosceles?, "Expected 'true', triangle [0.5, 0.4, 0.5] is isosceles."
7777
end
7878

79-
def test_triangle_[5_4_6]_is_scalene_if_no_sides_are_equal
79+
def test_triangle_is_scalene_if_no_sides_are_equal
8080
skip
8181
triangle = Triangle.new([5, 4, 6])
8282
assert triangle.scalene?, "Expected 'true', triangle [5, 4, 6] is scalene."
8383
end
8484

85-
def test_triangle_[4_4_4]_is_not_scalene_if_all_sides_are_equal
85+
def test_triangle_is_not_scalene_if_all_sides_are_equal
8686
skip
8787
triangle = Triangle.new([4, 4, 4])
8888
refute triangle.scalene?, "Expected 'false', triangle [4, 4, 4] is not scalene."
8989
end
9090

91-
def test_triangle_[4_4_3]_is_not_scalene_if_two_sides_are_equal
91+
def test_triangle_is_not_scalene_if_two_sides_are_equal
9292
skip
9393
triangle = Triangle.new([4, 4, 3])
9494
refute triangle.scalene?, "Expected 'false', triangle [4, 4, 3] is not scalene."

0 commit comments

Comments
 (0)