Merge pull request #503 from Insti/start_unit_testing_generator

Start unit testing lib/generator

Author: kotp

Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 gem 'minitest'
 gem 'rubocop', '0.36.0'
+gem 'simplecov'
+gem 'rake'

Rakefile

@@ -0,0 +1,6 @@
+require 'rake'
+require 'rake/testtask'
+
+Rake::TestTask.new do |task|
+  task.pattern = 'test/*_test.rb'
+end

bin/executable-tests-check

@@ -3,7 +3,7 @@ require 'minitest/autorun'
 
 # Assume that this file lives in #{base}/bin
 base = File.join(__dir__,'..')
-files = Dir.glob("#{base}/**/*test.rb") + Dir.glob("#{base}/bin/*")
+files = Dir.glob("#{base}/exercises/**/*test.rb") + Dir.glob("#{base}/bin/*")
 
 files.each do |file|
   describe file do

config.json

@@ -517,7 +517,8 @@
   "ignored": [
     "docs",
     "img",
-    "lib"
+    "lib",
+    "test"
   ],
   "foregone": [
 

lib/generator.rb

@@ -8,17 +8,22 @@ class Generator
   METADATA_REPOSITORY = 'x-common'.freeze
 
   attr_reader :name, :cases
-  def initialize(name, cases)
+  def initialize(name, cases, metadata_repository_path=nil)
     @name = name
     @cases = cases
+    @metadata_repository_path = metadata_repository_path || default_metadata_path
+  end
+
+  def default_metadata_path
+    File.join( '..', METADATA_REPOSITORY)
   end
 
   def metadata_dir
-    File.expand_path(File.join('..', '..', '..', METADATA_REPOSITORY, 'exercises', name), __FILE__)
+    File.join(@metadata_repository_path, 'exercises', name)
   end
 
   def exercise_dir
-    File.expand_path(File.join('..', '..', 'exercises', name), __FILE__)
+    File.join('exercises', name)
   end
 
   def exercise_meta_dir

test/generator_test.rb

@@ -0,0 +1,21 @@
+require_relative 'test_helper'
+
+class GeneratorTest < Minitest::Test
+  def test_default_metadata_path
+    subject = Generator.new('aname', nil)
+    # This is relative to the xruby root
+    assert_equal '../x-common/exercises/aname', subject.metadata_dir
+  end
+
+  def test_initalize_with_fixture_path
+    fixture_path = 'xruby/test/fixtures'
+    subject = Generator.new('aname', nil, fixture_path)
+    assert_equal 'xruby/test/fixtures/exercises/aname', subject.metadata_dir
+  end
+
+  def test_exercise_dir
+    subject = Generator.new('aname', nil)
+    # This is relative to the xruby root
+    assert_equal 'exercises/aname', subject.exercise_dir
+  end
+end

test/test_helper.rb

@@ -0,0 +1,16 @@
+$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+
+require 'simplecov'
+require 'minitest/autorun'
+require 'minitest/pride'
+
+SimpleCov.start do
+  add_filter '/tests/'
+  add_group 'Utilities' do |file|
+    !(file.filename =~ /_cases\.rb$/)
+  end
+  add_group 'Cases', '_cases.rb'
+end
+
+# So we can be sure we have coverage on the whole lib directory:
+Dir.glob('lib/*.rb').each { |file| require file.gsub(%r{(^lib\/|\.rb$)}, '') }