Skip to content

rna-transcription: specify error cases using error-object #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NobbZ opened this issue Oct 29, 2017 · 2 comments · Fixed by #1027
Closed

rna-transcription: specify error cases using error-object #977

NobbZ opened this issue Oct 29, 2017 · 2 comments · Fixed by #1027

Comments

@NobbZ
Copy link
Member

NobbZ commented Oct 29, 2017

Currently there are 3 error cases in rna-transcriptions canonical-data.json.

Those are specified using an expected value of null instead of the “new” and more flexible way of using an error object.

Should we change this? And is this error-object described/specified somewhere in a human readable way?

@Insti
Copy link
Contributor

Insti commented Oct 30, 2017

Yes we should change this.

The error object is specified in the README in the Test Data Format section.

if an error is expected (because the input is invalid, or any other reason), the value at "expected" should be an object containing exactly one property, "error", whose value is a string.

@ErikSchierboom
Copy link
Member

Should we change this?

Absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants