From e0f7da9fd793ab327f072abb48cb1cb9b09b3607 Mon Sep 17 00:00:00 2001 From: Ben Coman Date: Wed, 5 Jun 2019 22:20:42 +0800 Subject: [PATCH 1/6] ETL descriptions too long Such a long test is really a comment, not a description to be used as a test identifier. Make it so, per #1473 --- exercises/etl/canonical-data.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/exercises/etl/canonical-data.json b/exercises/etl/canonical-data.json index ceef40e354..37addc62fe 100644 --- a/exercises/etl/canonical-data.json +++ b/exercises/etl/canonical-data.json @@ -10,7 +10,10 @@ "such that keys are integers. e.g. in JavaScript, it might look ", "like `transform( { 1: ['A'] } );`" ], - "description": "transforms the a set of scrabble data previously indexed by the tile score to a set of data indexed by the tile letter", + "description": "Transform", + "comments": [ "Transforms the a set of scrabble data previously indexed by the tile score", + "to a set of data indexed by the tile letter" + ], "cases": [ { "description": "a single letter", From 662b37007cd2cda453d67ea03d6e617a4a29f358 Mon Sep 17 00:00:00 2001 From: Ben Coman Date: Wed, 5 Jun 2019 23:54:21 +0800 Subject: [PATCH 2/6] expand description, response to @sleeplessbyte suggestion --- exercises/etl/canonical-data.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exercises/etl/canonical-data.json b/exercises/etl/canonical-data.json index 37addc62fe..3cfd862bfa 100644 --- a/exercises/etl/canonical-data.json +++ b/exercises/etl/canonical-data.json @@ -10,9 +10,9 @@ "such that keys are integers. e.g. in JavaScript, it might look ", "like `transform( { 1: ['A'] } );`" ], - "description": "Transform", - "comments": [ "Transforms the a set of scrabble data previously indexed by the tile score", - "to a set of data indexed by the tile letter" + "description": "Transform legacy to new", + "comments": [ "Transforms a set of legacy scrabble data stored as letters per score", + "to a set of data stored score per letter" ], "cases": [ { From c5b6f8c46ba44a85b5aa12ad64d5762cfef4855f Mon Sep 17 00:00:00 2001 From: Ben Coman Date: Thu, 13 Jun 2019 00:32:04 +0800 Subject: [PATCH 3/6] Correctly add to existing comment --- exercises/etl/canonical-data.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exercises/etl/canonical-data.json b/exercises/etl/canonical-data.json index 3cfd862bfa..5907c7b708 100644 --- a/exercises/etl/canonical-data.json +++ b/exercises/etl/canonical-data.json @@ -4,6 +4,8 @@ "cases": [ { "comments": [ + "Transforms a set of legacy scrabble data stored as letters per score", + "to a set of data stored score per letter." "Note: The expected input data for these tests should have", "integer keys (not stringified numbers as shown in the JSON below", "Unless the language prohibits that, please implement these tests", @@ -11,12 +13,10 @@ "like `transform( { 1: ['A'] } );`" ], "description": "Transform legacy to new", - "comments": [ "Transforms a set of legacy scrabble data stored as letters per score", - "to a set of data stored score per letter" ], "cases": [ { - "description": "a single letter", + "description": "single letter", "property": "transform", "input": { "1": ["A"] From 7e043b32c1ced67b05e1742e042d2b6866315fc1 Mon Sep 17 00:00:00 2001 From: Ben Coman Date: Thu, 13 Jun 2019 01:05:14 +0800 Subject: [PATCH 4/6] and bump version --- exercises/etl/canonical-data.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/etl/canonical-data.json b/exercises/etl/canonical-data.json index 5907c7b708..70c305604b 100644 --- a/exercises/etl/canonical-data.json +++ b/exercises/etl/canonical-data.json @@ -1,6 +1,6 @@ { "exercise": "etl", - "version": "1.0.0", + "version": "1.0.1", "cases": [ { "comments": [ From 79fb5b7b11928c1a72a339e61b2c6b26045d24be Mon Sep 17 00:00:00 2001 From: Ben Coman Date: Thu, 13 Jun 2019 03:48:26 +0800 Subject: [PATCH 5/6] fix missing comma Co-Authored-By: Erik Schierboom --- exercises/etl/canonical-data.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/etl/canonical-data.json b/exercises/etl/canonical-data.json index 70c305604b..df474372a7 100644 --- a/exercises/etl/canonical-data.json +++ b/exercises/etl/canonical-data.json @@ -5,7 +5,7 @@ { "comments": [ "Transforms a set of legacy scrabble data stored as letters per score", - "to a set of data stored score per letter." + "to a set of data stored score per letter.", "Note: The expected input data for these tests should have", "integer keys (not stringified numbers as shown in the JSON below", "Unless the language prohibits that, please implement these tests", From 933657da7f9afe0aad5c98178e4c48c4c778e8bb Mon Sep 17 00:00:00 2001 From: Ben Coman Date: Thu, 13 Jun 2019 03:53:51 +0800 Subject: [PATCH 6/6] also fix surplus square bracket --- exercises/etl/canonical-data.json | 1 - 1 file changed, 1 deletion(-) diff --git a/exercises/etl/canonical-data.json b/exercises/etl/canonical-data.json index df474372a7..8ecc4cdda1 100644 --- a/exercises/etl/canonical-data.json +++ b/exercises/etl/canonical-data.json @@ -13,7 +13,6 @@ "like `transform( { 1: ['A'] } );`" ], "description": "Transform legacy to new", - ], "cases": [ { "description": "single letter",