From 79435f9a93d91b3aa9d478544fe60f368ad3fbc3 Mon Sep 17 00:00:00 2001 From: ee7 <45465154+ee7@users.noreply.github.com> Date: Sun, 27 Dec 2020 21:30:01 +0100 Subject: [PATCH] grade-school: Change a UUID to be version 4 Commit 03529d08e743 (#1735) added a new test case for the `grade-school` exercise, but the UUID added was version 1 rather than version 4. This was not caught by CI because the regex in the schema validator was too permissive (fixed by #1759). Some reasons to prefer version 4 UUIDs: - Version 4 is the right version for a fully random and unique identifer; we don't want to indicate anything about the machine that generated the UUID, and version 1 UUIDs have a timestamp and MAC address component. - All of the other UUIDs currently in `problem-specifications` are valid version 4 UUIDs. - `configlet uuid` generates a version 4 UUID. - A reader familiar with the UUID specification (RFC 4122) might see a version 1 UUID and infer that the timestamp or MAC address component is useful, causing them to wonder why the others are version 4. - A user who generates a version 1 UUID might unintentionally leak their MAC address. See also: - https://tools.ietf.org/html/rfc4122.html --- exercises/grade-school/canonical-data.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/grade-school/canonical-data.json b/exercises/grade-school/canonical-data.json index 61f78ac529..51210d8330 100644 --- a/exercises/grade-school/canonical-data.json +++ b/exercises/grade-school/canonical-data.json @@ -15,7 +15,7 @@ "expected": ["Aimee"] }, { - "uuid": "dece43c8-3ba5-11eb-8fdf-7f8daeaeb5f2", + "uuid": "c125dab7-2a53-492f-a99a-56ad511940d8", "description": "A student can't be in two different grades", "property": "roster", "input": {