From cd7f95109103e6f4b4272a1150dcb38249961984 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Gillet?= Date: Wed, 20 Apr 2022 22:30:15 +0900 Subject: [PATCH 1/3] `state-of-tic-tac-toe`: unique descriptions for test cases --- .../state-of-tic-tac-toe/canonical-data.json | 46 +++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/exercises/state-of-tic-tac-toe/canonical-data.json b/exercises/state-of-tic-tac-toe/canonical-data.json index fbab9b562a..69bb3ca731 100644 --- a/exercises/state-of-tic-tac-toe/canonical-data.json +++ b/exercises/state-of-tic-tac-toe/canonical-data.json @@ -6,7 +6,7 @@ "cases": [ { "uuid": "fe8e9fa9-37af-4d7e-aa24-2f4b8517161a", - "description": "Finished game where X won via column victory", + "description": "Finished game where X won via first column victory", "property": "gamestate", "input": { "board": [ @@ -19,7 +19,7 @@ }, { "uuid": "96c30df5-ae23-4cf6-bf09-5ef056dddea1", - "description": "Finished game where X won via column victory", + "description": "Finished game where X won via second column victory", "property": "gamestate", "input": { "board": [ @@ -32,7 +32,7 @@ }, { "uuid": "0d7a4b0a-2afd-4a75-8389-5fb88ab05eda", - "description": "Finished game where X won via column victory", + "description": "Finished game where X won via third column victory", "property": "gamestate", "input": { "board": [ @@ -45,7 +45,7 @@ }, { "uuid": "bd1007c0-ec5d-4c60-bb9f-1a4f22177d51", - "description": "Finished game where O won via column victory", + "description": "Finished game where O won via first column victory", "property": "gamestate", "input": { "board": [ @@ -58,7 +58,7 @@ }, { "uuid": "c032f800-5735-4354-b1b9-46f14d4ee955", - "description": "Finished game where O won via column victory", + "description": "Finished game where O won via second column victory", "property": "gamestate", "input": { "board": [ @@ -71,7 +71,7 @@ }, { "uuid": "662c8902-c94a-4c4c-9d9c-e8ca513db2b4", - "description": "Finished game where O won via column victory", + "description": "Finished game where O won via third column victory", "property": "gamestate", "input": { "board": [ @@ -84,7 +84,7 @@ }, { "uuid": "2d62121f-7e3a-44a0-9032-0d73e3494941", - "description": "Finished game where X won via row victory", + "description": "Finished game where X won via first row victory", "property": "gamestate", "input": { "board": [ @@ -97,7 +97,7 @@ }, { "uuid": "108a5e82-cc61-409f-aece-d7a18c1beceb", - "description": "Finished game where X won via row victory", + "description": "Finished game where X won via second row victory", "property": "gamestate", "input": { "board": [ @@ -110,7 +110,7 @@ }, { "uuid": "a013c583-75f8-4ab2-8d68-57688ff04574", - "description": "Finished game where X won via row victory", + "description": "Finished game where X won via third row victory", "property": "gamestate", "input": { "board": [ @@ -123,7 +123,7 @@ }, { "uuid": "2c08e7d7-7d00-487f-9442-e7398c8f1727", - "description": "Finished game where O won via row victory", + "description": "Finished game where O won via first row victory", "property": "gamestate", "input": { "board": [ @@ -136,7 +136,7 @@ }, { "uuid": "bb1d6c62-3e3f-4d1a-9766-f8803c8ed70f", - "description": "Finished game where O won via row victory", + "description": "Finished game where O won via second row victory", "property": "gamestate", "input": { "board": [ @@ -149,7 +149,7 @@ }, { "uuid": "6ef641e9-12ec-44f5-a21c-660ea93907af", - "description": "Finished game where O won via row victory", + "description": "Finished game where O won via third row victory", "property": "gamestate", "input": { "board": [ @@ -162,7 +162,7 @@ }, { "uuid": "ab145b7b-26a7-426c-ab71-bf418cd07f81", - "description": "Finished game where X won via diagonal victory", + "description": "Finished game where X won via first diagonal victory", "property": "gamestate", "input": { "board": [ @@ -175,7 +175,7 @@ }, { "uuid": "7450caab-08f5-4f03-a74b-99b98c4b7a4b", - "description": "Finished game where X won via diagonal victory", + "description": "Finished game where X won via second diagonal victory", "property": "gamestate", "input": { "board": [ @@ -188,7 +188,7 @@ }, { "uuid": "c2a652ee-2f93-48aa-a710-a70cd2edce61", - "description": "Finished game where O won via diagonal victory", + "description": "Finished game where O won via first diagonal victory", "property": "gamestate", "input": { "board": [ @@ -201,7 +201,7 @@ }, { "uuid": "5b20ceea-494d-4f0c-a986-b99efc163bcf", - "description": "Finished game where O won via diagonal victory", + "description": "Finished game where O won via second diagonal victory", "property": "gamestate", "input": { "board": [ @@ -245,7 +245,7 @@ "cases": [ { "uuid": "b42ed767-194c-4364-b36e-efbfb3de8788", - "description": "Draw", + "description": "Draw (1)", "property": "gamestate", "input": { "board": [ @@ -258,7 +258,7 @@ }, { "uuid": "227a76b2-0fef-4e16-a4bd-8f9d7e4c3b13", - "description": "Draw", + "description": "Draw (2)", "property": "gamestate", "input": { "board": [ @@ -276,7 +276,7 @@ "cases": [ { "uuid": "4d93f15c-0c40-43d6-b966-418b040012a9", - "description": "Ongoing game", + "description": "Ongoing game: one move in", "property": "gamestate", "input": { "board": [ @@ -289,7 +289,7 @@ }, { "uuid": "c407ae32-4c44-4989-b124-2890cf531f19", - "description": "Ongoing game", + "description": "Ongoing game: two moves in", "property": "gamestate", "input": { "board": [ @@ -302,7 +302,7 @@ }, { "uuid": "199b7a8d-e2b6-4526-a85e-78b416e7a8a9", - "description": "Ongoing game", + "description": "Ongoing game: five moves in", "property": "gamestate", "input": { "board": [ @@ -320,7 +320,7 @@ "cases": [ { "uuid": "1670145b-1e3d-4269-a7eb-53cd327b302e", - "description": "Invalid board", + "description": "Invalid board: X went twice", "property": "gamestate", "input": { "board": [ @@ -335,7 +335,7 @@ }, { "uuid": "47c048e8-b404-4bcf-9e51-8acbb3253f3b", - "description": "Invalid board", + "description": "Invalid board: O started", "property": "gamestate", "input": { "board": [ From 78ae4e4ff317ef0e676e7caadf6194448bb271c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Gillet?= Date: Thu, 21 Apr 2022 22:05:35 +0900 Subject: [PATCH 2/3] Tweak draw descriptions --- exercises/state-of-tic-tac-toe/canonical-data.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/state-of-tic-tac-toe/canonical-data.json b/exercises/state-of-tic-tac-toe/canonical-data.json index 69bb3ca731..8728e49489 100644 --- a/exercises/state-of-tic-tac-toe/canonical-data.json +++ b/exercises/state-of-tic-tac-toe/canonical-data.json @@ -245,7 +245,7 @@ "cases": [ { "uuid": "b42ed767-194c-4364-b36e-efbfb3de8788", - "description": "Draw (1)", + "description": "Draw", "property": "gamestate", "input": { "board": [ @@ -258,7 +258,7 @@ }, { "uuid": "227a76b2-0fef-4e16-a4bd-8f9d7e4c3b13", - "description": "Draw (2)", + "description": "Another draw", "property": "gamestate", "input": { "board": [ From 45c517911bad4d8e193b9ef1e239842d4fa93134 Mon Sep 17 00:00:00 2001 From: Jie Date: Fri, 22 Apr 2022 08:31:51 +0900 Subject: [PATCH 3/3] More precise description of which row/column/diagonal Co-authored-by: Peter Tseng --- .../state-of-tic-tac-toe/canonical-data.json | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/exercises/state-of-tic-tac-toe/canonical-data.json b/exercises/state-of-tic-tac-toe/canonical-data.json index 8728e49489..6a0e55a358 100644 --- a/exercises/state-of-tic-tac-toe/canonical-data.json +++ b/exercises/state-of-tic-tac-toe/canonical-data.json @@ -6,7 +6,7 @@ "cases": [ { "uuid": "fe8e9fa9-37af-4d7e-aa24-2f4b8517161a", - "description": "Finished game where X won via first column victory", + "description": "Finished game where X won via left column victory", "property": "gamestate", "input": { "board": [ @@ -19,7 +19,7 @@ }, { "uuid": "96c30df5-ae23-4cf6-bf09-5ef056dddea1", - "description": "Finished game where X won via second column victory", + "description": "Finished game where X won via middle column victory", "property": "gamestate", "input": { "board": [ @@ -32,7 +32,7 @@ }, { "uuid": "0d7a4b0a-2afd-4a75-8389-5fb88ab05eda", - "description": "Finished game where X won via third column victory", + "description": "Finished game where X won via right column victory", "property": "gamestate", "input": { "board": [ @@ -45,7 +45,7 @@ }, { "uuid": "bd1007c0-ec5d-4c60-bb9f-1a4f22177d51", - "description": "Finished game where O won via first column victory", + "description": "Finished game where O won via left column victory", "property": "gamestate", "input": { "board": [ @@ -58,7 +58,7 @@ }, { "uuid": "c032f800-5735-4354-b1b9-46f14d4ee955", - "description": "Finished game where O won via second column victory", + "description": "Finished game where O won via middle column victory", "property": "gamestate", "input": { "board": [ @@ -71,7 +71,7 @@ }, { "uuid": "662c8902-c94a-4c4c-9d9c-e8ca513db2b4", - "description": "Finished game where O won via third column victory", + "description": "Finished game where O won via right column victory", "property": "gamestate", "input": { "board": [ @@ -84,7 +84,7 @@ }, { "uuid": "2d62121f-7e3a-44a0-9032-0d73e3494941", - "description": "Finished game where X won via first row victory", + "description": "Finished game where X won via top row victory", "property": "gamestate", "input": { "board": [ @@ -97,7 +97,7 @@ }, { "uuid": "108a5e82-cc61-409f-aece-d7a18c1beceb", - "description": "Finished game where X won via second row victory", + "description": "Finished game where X won via middle row victory", "property": "gamestate", "input": { "board": [ @@ -110,7 +110,7 @@ }, { "uuid": "a013c583-75f8-4ab2-8d68-57688ff04574", - "description": "Finished game where X won via third row victory", + "description": "Finished game where X won via bottom row victory", "property": "gamestate", "input": { "board": [ @@ -123,7 +123,7 @@ }, { "uuid": "2c08e7d7-7d00-487f-9442-e7398c8f1727", - "description": "Finished game where O won via first row victory", + "description": "Finished game where O won via top row victory", "property": "gamestate", "input": { "board": [ @@ -136,7 +136,7 @@ }, { "uuid": "bb1d6c62-3e3f-4d1a-9766-f8803c8ed70f", - "description": "Finished game where O won via second row victory", + "description": "Finished game where O won via middle row victory", "property": "gamestate", "input": { "board": [ @@ -149,7 +149,7 @@ }, { "uuid": "6ef641e9-12ec-44f5-a21c-660ea93907af", - "description": "Finished game where O won via third row victory", + "description": "Finished game where O won via bottom row victory", "property": "gamestate", "input": { "board": [ @@ -162,7 +162,7 @@ }, { "uuid": "ab145b7b-26a7-426c-ab71-bf418cd07f81", - "description": "Finished game where X won via first diagonal victory", + "description": "Finished game where X won via falling diagonal victory", "property": "gamestate", "input": { "board": [ @@ -175,7 +175,7 @@ }, { "uuid": "7450caab-08f5-4f03-a74b-99b98c4b7a4b", - "description": "Finished game where X won via second diagonal victory", + "description": "Finished game where X won via rising diagonal victory", "property": "gamestate", "input": { "board": [ @@ -188,7 +188,7 @@ }, { "uuid": "c2a652ee-2f93-48aa-a710-a70cd2edce61", - "description": "Finished game where O won via first diagonal victory", + "description": "Finished game where O won via falling diagonal victory", "property": "gamestate", "input": { "board": [ @@ -201,7 +201,7 @@ }, { "uuid": "5b20ceea-494d-4f0c-a986-b99efc163bcf", - "description": "Finished game where O won via second diagonal victory", + "description": "Finished game where O won via rising diagonal victory", "property": "gamestate", "input": { "board": [