bowling: tested and implemeneted first 14 tests

Author: thecouchcoder

exercises/bowling/bowling_test.py

@@ -103,6 +103,62 @@ def test_consecutive_stikes_each_get_the_two_roll_bonus(self):
 
         self.assertEqual(score, 81)
 
+    def test_strike_in_last_frame_gets_two_roll_bonus_counted_once(self):
+        rolls = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 7, 1]
+
+        self.game = BowlingGame()
+
+        for roll in rolls:
+            self.game.roll(roll)
+        score = self.game.score()
+
+        self.assertEqual(score, 18)
+
+    def test_rolling_spare_with_bonus_roll_does_not_get_bonus(self):
+        rolls = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 7, 3]
+
+        self.game = BowlingGame()
+
+        for roll in rolls:
+            self.game.roll(roll)
+        score = self.game.score()
+
+        self.assertEqual(score, 20)
+
+    def test_strikes_with_the_two_bonus_rolls_do_not_get_bonus_rolls(self):
+        rolls = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 10, 10]
+
+        self.game = BowlingGame()
+
+        for roll in rolls:
+            self.game.roll(roll)
+        score = self.game.score()
+
+        self.assertEqual(score, 30)
+
+    def test_strike_with_bonus_after_spare_in_last_frame_gets_no_bonus(self):
+        rolls = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 7, 3, 10]
+
+        self.game = BowlingGame()
+
+        for roll in rolls:
+            self.game.roll(roll)
+        score = self.game.score()
+
+        self.assertEqual(score, 20)
+
+    def test_all_strikes_is_a_perfect_game(self):
+
+        rolls = [10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10]
+
+        self.game = BowlingGame()
+
+        for roll in rolls:
+            self.game.roll(roll)
+        score = self.game.score()
+
+        self.assertEqual(score, 300)
+
 
 if __name__ == '__main__':
     unittest.main()

exercises/bowling/example.py

@@ -13,28 +13,31 @@ def roll(self, pins):
 
     def score(self):
         roll_index = 0
+        frame_index = 1
 
-        while (roll_index < len(self.rolls)-1):
-
-            #get the two rolls that make up a frame
+        while (frame_index <= NUM_FRAMES):
+            # get the two rolls that make up a frame
             roll1 = self.rolls[roll_index]
             if(not self.isLastFrame(roll_index)):
-                roll2 = self.rolls[roll_index  + 1]
+                roll2 = self.rolls[roll_index + 1]
             else:
                 roll2 = 0
 
             if (self.isStrike(roll1)):
                 self.totalScore += roll1 + self.stikeBonus(roll_index)
-                #frame should only advance by 1 roll if it was a strike
+                # frame should only advance by 1 roll if it was a strike
                 roll_index += 1
             else:
                 if(self.isSpare(roll1, roll2)):
-                    self.totalScore += roll1 + roll2 + self.spareBonus(roll_index)
+                    self.totalScore += roll1 + roll2 + \
+                                       self.spareBonus(roll_index)
                 else:
                     self.totalScore += roll1 + roll2
-                #frame should only advance by 2 rolls normally
+                # frame should advance by 2 rolls normally
                 roll_index += 2
 
+            frame_index += 1
+
         return self.totalScore
 
     def isStrike(self, pins):