Skip to content

Investigate issues with configlet lint in Travis-CI builds #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmccandless opened this issue Feb 26, 2019 · 3 comments
Closed

Investigate issues with configlet lint in Travis-CI builds #1691

cmccandless opened this issue Feb 26, 2019 · 3 comments
Assignees

Comments

@cmccandless
Copy link
Contributor

As observed in #1690 (comment), configlet lint may not be catching everything it is supposed to in our Travis builds (latest build as of this writing passed without issue).

It is unlikely that the issue is with configlet itself, as that same tool was used to find the very violations that CI builds missed, so there is probably an issue with how the builds are configured.

@cmccandless cmccandless self-assigned this Feb 26, 2019
@cmccandless
Copy link
Contributor Author

@junming403 Can you confirm what version of configlet you used to lint in #1690?

@junming403
Copy link
Contributor

There is a script fetch-configlet in code base.

@cmccandless
Copy link
Contributor Author

After further investigation: I have determined there is no issue with configlet lint. The issues found in #1690 were changes made by config fmt, and are not called out by configlet lint.

@junming403 can you please confirm that you did run configlet fmt . in #1690?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants