From 6c8585709c54b84e6ae1e90ee0804ac67908a88b Mon Sep 17 00:00:00 2001 From: kishan Date: Wed, 25 Oct 2017 17:25:40 +0530 Subject: [PATCH 1/6] Updated Test Version. --- exercises/hamming/hamming_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/hamming/hamming_test.py b/exercises/hamming/hamming_test.py index 15cd14bb72..6f1405830a 100644 --- a/exercises/hamming/hamming_test.py +++ b/exercises/hamming/hamming_test.py @@ -3,7 +3,7 @@ import hamming -# test cases adapted from `x-common//canonical-data.json` @ version: 1.0.0 +# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 class HammingTest(unittest.TestCase): From 72d763e281568a4e50c8ab8b4f6ef7e1f69b6050 Mon Sep 17 00:00:00 2001 From: kishan Date: Wed, 25 Oct 2017 17:26:54 +0530 Subject: [PATCH 2/6] Updated correct Test Version 2.0.1 --- exercises/hamming/hamming_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/hamming/hamming_test.py b/exercises/hamming/hamming_test.py index 6f1405830a..c6695b9f3d 100644 --- a/exercises/hamming/hamming_test.py +++ b/exercises/hamming/hamming_test.py @@ -3,7 +3,7 @@ import hamming -# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 +# Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.1 class HammingTest(unittest.TestCase): From 907b8d479def4ef24062119bf32db5a802c0eca8 Mon Sep 17 00:00:00 2001 From: kishan Date: Wed, 25 Oct 2017 17:48:54 +0530 Subject: [PATCH 3/6] Updated Tests --- exercises/hamming/hamming_test.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/exercises/hamming/hamming_test.py b/exercises/hamming/hamming_test.py index c6695b9f3d..0102505906 100644 --- a/exercises/hamming/hamming_test.py +++ b/exercises/hamming/hamming_test.py @@ -6,7 +6,10 @@ # Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.1 class HammingTest(unittest.TestCase): - + + def test_identical_strands(self): + self.assertEqual(hamming.distance("", ""), 0) + def test_identical_strands(self): self.assertEqual(hamming.distance("A", "A"), 0) From e8f06baf275864debb98cc49fff4a5a7a2d2896c Mon Sep 17 00:00:00 2001 From: kishan Date: Thu, 26 Oct 2017 09:22:26 +0530 Subject: [PATCH 4/6] hamming: update tests to version 2.0.1 Resolves #1031 --- exercises/hamming/hamming_test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exercises/hamming/hamming_test.py b/exercises/hamming/hamming_test.py index 0102505906..997a2da395 100644 --- a/exercises/hamming/hamming_test.py +++ b/exercises/hamming/hamming_test.py @@ -6,10 +6,10 @@ # Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.1 class HammingTest(unittest.TestCase): - - def test_identical_strands(self): + + def test_empty_strands(self): self.assertEqual(hamming.distance("", ""), 0) - + def test_identical_strands(self): self.assertEqual(hamming.distance("A", "A"), 0) From af7e2ff5622a1b6e888a797c58f89410dd0e56cb Mon Sep 17 00:00:00 2001 From: kishan Date: Thu, 26 Oct 2017 14:15:37 +0530 Subject: [PATCH 5/6] Remove redundant test. --- exercises/hamming/hamming_test.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/exercises/hamming/hamming_test.py b/exercises/hamming/hamming_test.py index 997a2da395..5f02b0d054 100644 --- a/exercises/hamming/hamming_test.py +++ b/exercises/hamming/hamming_test.py @@ -46,9 +46,6 @@ def test_large_distance(self): def test_large_distance_in_off_by_one_strand(self): self.assertEqual(hamming.distance("GGACGGATTCTG", "AGGACGGATTCT"), 9) - def test_empty_strands(self): - self.assertEqual(hamming.distance("", ""), 0) - def test_disallow_first_strand_longer(self): with self.assertRaises(ValueError): hamming.distance("AATG", "AAA") From 0062a80fa0062f259f04e94eebb72cc0de7a8535 Mon Sep 17 00:00:00 2001 From: kishan Date: Thu, 26 Oct 2017 18:53:43 +0530 Subject: [PATCH 6/6] Try to fix build as per guidance. --- exercises/hamming/hamming_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/hamming/hamming_test.py b/exercises/hamming/hamming_test.py index 5f02b0d054..77dc6823cf 100644 --- a/exercises/hamming/hamming_test.py +++ b/exercises/hamming/hamming_test.py @@ -32,10 +32,10 @@ def test_small_distance_in_long_strands(self): self.assertEqual(hamming.distance("ACCAGGG", "ACTATGG"), 2) def test_non_unique_character_in_first_strand(self): - self.assertEqual(hamming.distance("AGA", "AGG"), 1) + self.assertEqual(hamming.distance("AAG", "AAA"), 1) def test_non_unique_character_in_second_strand(self): - self.assertEqual(hamming.distance("AGG", "AGA"), 1) + self.assertEqual(hamming.distance("AAA", "AAG"), 1) def test_same_nucleotides_in_different_positions(self): self.assertEqual(hamming.distance("TAG", "GAT"), 2)