From ce844c4ef95831bc35278bf7a9e813b1e69645b6 Mon Sep 17 00:00:00 2001 From: mRcfps <1402491442@qq.com> Date: Sat, 17 Feb 2018 16:16:51 +0800 Subject: [PATCH] saddle-points: update tests to v1.1.0 * Conform test method name to canonical description * Rename variable `inp` and `ans` to `matrix` and `expected` --- exercises/saddle-points/saddle_points_test.py | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/exercises/saddle-points/saddle_points_test.py b/exercises/saddle-points/saddle_points_test.py index 9306790d8a..e36e0da88e 100644 --- a/exercises/saddle-points/saddle_points_test.py +++ b/exercises/saddle-points/saddle_points_test.py @@ -10,36 +10,36 @@ from saddle_points import saddle_points -# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0 +# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 class SaddlePointTest(unittest.TestCase): - def test_one_saddle(self): - inp = [[9, 8, 7], [5, 3, 2], [6, 6, 7]] - self.assertEqual(saddle_points(inp), set([(1, 0)])) + def test_identify_single_saddle_point(self): + matrix = [[9, 8, 7], [5, 3, 2], [6, 6, 7]] + self.assertEqual(saddle_points(matrix), set([(1, 0)])) - def test_empty_matrix(self): + def test_empty_matrix_has_no_saddle_points(self): self.assertEqual(saddle_points([]), set()) - def test_no_saddle(self): - inp = [[1, 2, 3], [3, 1, 2], [2, 3, 1]] - self.assertEqual(saddle_points(inp), set()) + def test_identify_lack_of_saddle_points_when_there_are_none(self): + matrix = [[1, 2, 3], [3, 1, 2], [2, 3, 1]] + self.assertEqual(saddle_points(matrix), set()) - def test_mult_saddle(self): - inp = [[4, 5, 4], [3, 5, 5], [1, 5, 4]] - ans = set([(0, 1), (1, 1), (2, 1)]) - self.assertEqual(saddle_points(inp), ans) + def test_identify_multiple_saddle_points(self): + matrix = [[4, 5, 4], [3, 5, 5], [1, 5, 4]] + expected = set([(0, 1), (1, 1), (2, 1)]) + self.assertEqual(saddle_points(matrix), expected) - def test_indentify_saddle_bottom_right_corner(self): - inp = [[8, 7, 9], [6, 7, 6], [3, 2, 5]] - ans = set([(2, 2)]) - self.assertEqual(saddle_points(inp), ans) + def test_identify_saddle_point_in_bottom_right_corner(self): + matrix = [[8, 7, 9], [6, 7, 6], [3, 2, 5]] + expected = set([(2, 2)]) + self.assertEqual(saddle_points(matrix), expected) # Additional tests for this track def test_irregular_matrix(self): - inp = [[3, 2, 1], [0, 1], [2, 1, 0]] + matrix = [[3, 2, 1], [0, 1], [2, 1, 0]] with self.assertRaisesWithMessage(ValueError): - saddle_points(inp) + saddle_points(matrix) # Utility functions def setUp(self):