From b5e416f3645b514a6d0a3718b6922081d39b3a59 Mon Sep 17 00:00:00 2001 From: tealkine Date: Tue, 10 Oct 2017 14:29:58 +1000 Subject: [PATCH 1/6] Fixed ignores --- exercises/bob/tests/bob.rs | 1 + exercises/crypto-square/tests/crypto-square.rs | 7 +++++++ exercises/say/tests/say.rs | 1 + 3 files changed, 9 insertions(+) diff --git a/exercises/bob/tests/bob.rs b/exercises/bob/tests/bob.rs index de35c40fa..5c48a4121 100644 --- a/exercises/bob/tests/bob.rs +++ b/exercises/bob/tests/bob.rs @@ -63,6 +63,7 @@ fn test_shouting_numbers() { } #[test] +#[ignore] fn test_only_numbers() { assert_eq!("Whatever.", bob::reply("1, 2, 3")); } diff --git a/exercises/crypto-square/tests/crypto-square.rs b/exercises/crypto-square/tests/crypto-square.rs index acd9e71e1..087de1b60 100644 --- a/exercises/crypto-square/tests/crypto-square.rs +++ b/exercises/crypto-square/tests/crypto-square.rs @@ -12,6 +12,7 @@ fn test_empty_input() { #[test] +#[ignore] fn test_encrypt_also_decrypts_square() { // note that you only get the exact input back if: // 1. no punctuation @@ -23,6 +24,7 @@ fn test_encrypt_also_decrypts_square() { } #[test] +#[ignore] fn test_example() { test( "If man was meant to stay on the ground, god would have given us roots.", @@ -31,11 +33,13 @@ fn test_example() { } #[test] +#[ignore] fn test_empty_last_line() { test("congratulate", "crl oaa ntt gue") } #[test] +#[ignore] fn test_spaces_are_reorganized() { test("abet", "ae bt"); test("a bet", "ae bt"); @@ -43,6 +47,7 @@ fn test_spaces_are_reorganized() { } #[test] +#[ignore] fn test_everything_becomes_lowercase() { test("caSe", "cs ae"); test("cAsE", "cs ae"); @@ -50,6 +55,7 @@ fn test_everything_becomes_lowercase() { } #[test] +#[ignore] fn test_ignore_non_ascii_chars() { test( "She got her education, then got rich programming: 👩‍🎓🎓👩‍💻💰", @@ -58,6 +64,7 @@ fn test_ignore_non_ascii_chars() { } #[test] +#[ignore] fn test_long() { test( r#" diff --git a/exercises/say/tests/say.rs b/exercises/say/tests/say.rs index 06a08f99c..3f67e8c7f 100644 --- a/exercises/say/tests/say.rs +++ b/exercises/say/tests/say.rs @@ -20,6 +20,7 @@ fn test_negative() { */ #[test] +#[ignore] fn test_one() { assert_eq!(say::encode(1), String::from("one")); } From e0da8ae7b436e93c99e7c581607884a09461c981 Mon Sep 17 00:00:00 2001 From: tealkine Date: Tue, 10 Oct 2017 14:37:55 +1000 Subject: [PATCH 2/6] Missed say/tests/say.rs --- exercises/say/tests/say.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/exercises/say/tests/say.rs b/exercises/say/tests/say.rs index 3f67e8c7f..2c3507880 100644 --- a/exercises/say/tests/say.rs +++ b/exercises/say/tests/say.rs @@ -13,10 +13,14 @@ fn test_zero() { // If the below test is uncommented, it should not compile. // /* -#[test] -fn test_negative() { - assert_eq!(say::encode(-1), String::from("won't compile")); -} + + #[test] + #[ignore] + #[should_panic] + fn test_negative() { + assert_eq!(say::encode(-1), String::from("won't compile")); + } + */ #[test] From 411f305c696525c0191036cd4675f6a4ccf20694 Mon Sep 17 00:00:00 2001 From: f3rn0s Date: Tue, 10 Oct 2017 16:57:30 +1000 Subject: [PATCH 3/6] Fixed say incorrect should_panic --- exercises/say/tests/say.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/exercises/say/tests/say.rs b/exercises/say/tests/say.rs index 2c3507880..ad7e6737d 100644 --- a/exercises/say/tests/say.rs +++ b/exercises/say/tests/say.rs @@ -15,8 +15,6 @@ fn test_zero() { /* #[test] - #[ignore] - #[should_panic] fn test_negative() { assert_eq!(say::encode(-1), String::from("won't compile")); } From 0d515c9ce1e80afc4ca91b198abc049dc196015d Mon Sep 17 00:00:00 2001 From: f3rn0s Date: Tue, 10 Oct 2017 18:29:34 +1000 Subject: [PATCH 4/6] re-added ignore --- exercises/say/tests/say.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/exercises/say/tests/say.rs b/exercises/say/tests/say.rs index ad7e6737d..f0371dc2f 100644 --- a/exercises/say/tests/say.rs +++ b/exercises/say/tests/say.rs @@ -15,6 +15,7 @@ fn test_zero() { /* #[test] + #[ignoe] fn test_negative() { assert_eq!(say::encode(-1), String::from("won't compile")); } From 6c480f7e8b263f60d836d5adcf8025f6da478852 Mon Sep 17 00:00:00 2001 From: Peter Tseng Date: Tue, 10 Oct 2017 10:40:29 -0700 Subject: [PATCH 5/6] say: don't add spaces --- exercises/say/tests/say.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/exercises/say/tests/say.rs b/exercises/say/tests/say.rs index f0371dc2f..a2d73a839 100644 --- a/exercises/say/tests/say.rs +++ b/exercises/say/tests/say.rs @@ -13,13 +13,11 @@ fn test_zero() { // If the below test is uncommented, it should not compile. // /* - - #[test] - #[ignoe] - fn test_negative() { - assert_eq!(say::encode(-1), String::from("won't compile")); - } - +#[test] +#[ignoe] +fn test_negative() { + assert_eq!(say::encode(-1), String::from("won't compile")); +} */ #[test] From e671e8932266ae8b7c812c8a7c83c23978ae40d4 Mon Sep 17 00:00:00 2001 From: Peter Tseng Date: Tue, 10 Oct 2017 10:40:39 -0700 Subject: [PATCH 6/6] say: ignoe -> ignore --- exercises/say/tests/say.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/say/tests/say.rs b/exercises/say/tests/say.rs index a2d73a839..7d955cc33 100644 --- a/exercises/say/tests/say.rs +++ b/exercises/say/tests/say.rs @@ -14,7 +14,7 @@ fn test_zero() { // /* #[test] -#[ignoe] +#[ignore] fn test_negative() { assert_eq!(say::encode(-1), String::from("won't compile")); }