Skip to content

Fix timezone error in meetup #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mbertheau
Copy link
Contributor

Don't merge, since this doesn't fix anything yet.

The meetup test fails when run like this:

TZ=America/Chicago bin/check-exercises.sh

Still not working with, e.g.,  TZ=America/Chicago
@zenspider
Copy link
Contributor

Found it. The problem is that your use of seconds->date is also doing local timezone conversion. Pass #f as the second argument and it passes fine. I also have some other changes to the tests to make them more idiomatic. I'll try to figure out how to do a PR on your PR. :)

@zenspider
Copy link
Contributor

Added mbertheau#1

@kytrinyx
Copy link
Member

kytrinyx commented Aug 3, 2016

@exercism/lisp Would one of you have a moment to review this, please?

@kytrinyx
Copy link
Member

kytrinyx commented Aug 3, 2016

I've kicked off CI again.

@zenspider
Copy link
Contributor

@mbertheau ping. can you merge my PR to your PR?

@zenspider
Copy link
Contributor

I'll give this another week or so, and then if necessary I'll submit my own PR to supplant this one.

@mbertheau
Copy link
Contributor Author

@zenspider I'm busy with other things, please make a new PR :)

Thanks!

@mbertheau mbertheau closed this Aug 8, 2016
@zenspider
Copy link
Contributor

Will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants